Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(234)

Issue 2888093006: Place ellipsis correctly in inline blocks separated by spaces (Closed)

Created:
11 months, 1 week ago by rhogan
Modified:
11 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Place ellipsis correctly in inline blocks separated by spaces Include the offset given by objects containing collapsed text. Refine the position we use to determine which character to start the ellipsis at. BUG=133700 Review-Url: https://codereview.chromium.org/2888093006 Cr-Commit-Position: refs/heads/master@{#474365} Committed: https://chromium.googlesource.com/chromium/src/+/12be8ae4eb156601cc7e26e41199588b736bce38

Patch Set 1 #

Patch Set 2 : bug 133700 #

Patch Set 3 : bug 133700 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -16 lines) Patch
A third_party/WebKit/LayoutTests/fast/text/place-ellipsis-in-inline-blocks-2.html View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/place-mixed-ellipsis-in-inline-blocks-2.html View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/place-mixed-ellipsis-in-inline-blocks-align-center-2.html View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/place-mixed-ellipsis-in-inline-blocks-align-left-2.html View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/place-mixed-ellipsis-in-inline-blocks-align-right-2.html View 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/text/place-rtl-ellipsis-in-inline-blocks-2.html View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/place-ellipsis-in-inline-blocks-2-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/place-ellipsis-in-inline-blocks-align-center-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/place-ellipsis-in-inline-blocks-align-justify-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/place-ellipsis-in-inline-blocks-align-left-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/place-ellipsis-in-inline-blocks-align-right-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/place-ellipsis-in-inline-blocks-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/place-mixed-ellipsis-in-inline-blocks-2-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/place-mixed-ellipsis-in-inline-blocks-align-center-2-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/place-mixed-ellipsis-in-inline-blocks-align-center-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/place-mixed-ellipsis-in-inline-blocks-align-justify-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/place-mixed-ellipsis-in-inline-blocks-align-left-2-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/place-mixed-ellipsis-in-inline-blocks-align-left-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/place-mixed-ellipsis-in-inline-blocks-align-right-2-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/place-mixed-ellipsis-in-inline-blocks-align-right-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/place-mixed-ellipsis-in-inline-blocks-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/fast/text/place-rtl-ellipsis-in-inline-blocks-2-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-ellipsis-in-inline-blocks-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-ellipsis-in-inline-blocks-align-center-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-ellipsis-in-inline-blocks-align-justify-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-ellipsis-in-inline-blocks-align-left-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-ellipsis-in-inline-blocks-align-right-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-ellipsis-in-inline-blocks-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-mixed-ellipsis-in-inline-blocks-2-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-mixed-ellipsis-in-inline-blocks-align-center-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-mixed-ellipsis-in-inline-blocks-align-center-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-mixed-ellipsis-in-inline-blocks-align-justify-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-mixed-ellipsis-in-inline-blocks-align-left-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-mixed-ellipsis-in-inline-blocks-align-left-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-mixed-ellipsis-in-inline-blocks-align-right-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-mixed-ellipsis-in-inline-blocks-align-right-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-mixed-ellipsis-in-inline-blocks-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-rtl-ellipsis-in-inline-blocks-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-rtl-ellipsis-in-inline-blocks-align-center-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-rtl-ellipsis-in-inline-blocks-align-justify-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-rtl-ellipsis-in-inline-blocks-align-left-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-rtl-ellipsis-in-inline-blocks-align-right-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/place-rtl-ellipsis-in-inline-blocks-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-ellipsis-in-inline-blocks-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-ellipsis-in-inline-blocks-align-center-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-ellipsis-in-inline-blocks-align-justify-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-ellipsis-in-inline-blocks-align-left-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-ellipsis-in-inline-blocks-align-right-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-ellipsis-in-inline-blocks-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-mixed-ellipsis-in-inline-blocks-2-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-mixed-ellipsis-in-inline-blocks-align-center-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-mixed-ellipsis-in-inline-blocks-align-center-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-mixed-ellipsis-in-inline-blocks-align-justify-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-mixed-ellipsis-in-inline-blocks-align-left-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-mixed-ellipsis-in-inline-blocks-align-left-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-mixed-ellipsis-in-inline-blocks-align-right-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-mixed-ellipsis-in-inline-blocks-align-right-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-mixed-ellipsis-in-inline-blocks-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-rtl-ellipsis-in-inline-blocks-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-rtl-ellipsis-in-inline-blocks-align-center-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-rtl-ellipsis-in-inline-blocks-align-justify-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-rtl-ellipsis-in-inline-blocks-align-left-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-rtl-ellipsis-in-inline-blocks-align-right-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/place-rtl-ellipsis-in-inline-blocks-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/fast/text/place-ellipsis-in-inline-blocks-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/text/place-ellipsis-in-inline-blocks-align-center-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/text/place-ellipsis-in-inline-blocks-align-justify-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/text/place-ellipsis-in-inline-blocks-align-left-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/text/place-ellipsis-in-inline-blocks-align-right-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/text/place-ellipsis-in-inline-blocks-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/fast/text/place-mixed-ellipsis-in-inline-blocks-2-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/fast/text/place-mixed-ellipsis-in-inline-blocks-align-center-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/text/place-mixed-ellipsis-in-inline-blocks-align-center-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/text/place-mixed-ellipsis-in-inline-blocks-align-justify-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/fast/text/place-mixed-ellipsis-in-inline-blocks-align-left-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/text/place-mixed-ellipsis-in-inline-blocks-align-left-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/fast/text/place-mixed-ellipsis-in-inline-blocks-align-right-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/text/place-mixed-ellipsis-in-inline-blocks-align-right-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/text/place-mixed-ellipsis-in-inline-blocks-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/fast/text/place-rtl-ellipsis-in-inline-blocks-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/text/place-rtl-ellipsis-in-inline-blocks-align-center-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/text/place-rtl-ellipsis-in-inline-blocks-align-justify-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/text/place-rtl-ellipsis-in-inline-blocks-align-left-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/text/place-rtl-ellipsis-in-inline-blocks-align-right-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/text/place-rtl-ellipsis-in-inline-blocks-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/fast/text/place-ellipsis-in-inline-blocks-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/place-ellipsis-in-inline-blocks-align-center-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/place-ellipsis-in-inline-blocks-align-justify-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/place-ellipsis-in-inline-blocks-align-left-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/place-ellipsis-in-inline-blocks-align-right-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/place-ellipsis-in-inline-blocks-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/fast/text/place-mixed-ellipsis-in-inline-blocks-2-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/fast/text/place-mixed-ellipsis-in-inline-blocks-align-center-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/place-mixed-ellipsis-in-inline-blocks-align-center-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/place-mixed-ellipsis-in-inline-blocks-align-justify-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/fast/text/place-mixed-ellipsis-in-inline-blocks-align-left-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/place-mixed-ellipsis-in-inline-blocks-align-left-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/fast/text/place-mixed-ellipsis-in-inline-blocks-align-right-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/place-mixed-ellipsis-in-inline-blocks-align-right-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/place-mixed-ellipsis-in-inline-blocks-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/fast/text/place-rtl-ellipsis-in-inline-blocks-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/place-rtl-ellipsis-in-inline-blocks-align-center-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/place-rtl-ellipsis-in-inline-blocks-align-justify-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/place-rtl-ellipsis-in-inline-blocks-align-left-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/place-rtl-ellipsis-in-inline-blocks-align-right-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/text/place-rtl-ellipsis-in-inline-blocks-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win7/fast/text/place-ellipsis-in-inline-blocks-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/text/place-ellipsis-in-inline-blocks-align-center-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/text/place-ellipsis-in-inline-blocks-align-justify-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/text/place-ellipsis-in-inline-blocks-align-left-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/text/place-ellipsis-in-inline-blocks-align-right-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/text/place-ellipsis-in-inline-blocks-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win7/fast/text/place-mixed-ellipsis-in-inline-blocks-2-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win7/fast/text/place-mixed-ellipsis-in-inline-blocks-align-center-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/text/place-mixed-ellipsis-in-inline-blocks-align-center-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/text/place-mixed-ellipsis-in-inline-blocks-align-justify-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win7/fast/text/place-mixed-ellipsis-in-inline-blocks-align-left-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/text/place-mixed-ellipsis-in-inline-blocks-align-left-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win7/fast/text/place-mixed-ellipsis-in-inline-blocks-align-right-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/text/place-mixed-ellipsis-in-inline-blocks-align-right-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/text/place-mixed-ellipsis-in-inline-blocks-expected.png View 1 Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win7/fast/text/place-rtl-ellipsis-in-inline-blocks-2-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/text/place-rtl-ellipsis-in-inline-blocks-align-center-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/text/place-rtl-ellipsis-in-inline-blocks-align-justify-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/text/place-rtl-ellipsis-in-inline-blocks-align-left-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/text/place-rtl-ellipsis-in-inline-blocks-align-right-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win7/fast/text/place-rtl-ellipsis-in-inline-blocks-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp View 1 chunk +2 lines, -15 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
rhogan
11 months ago (2017-05-19 19:50:13 UTC) #9
eae
This is great, thank you! LGTM
11 months ago (2017-05-24 16:47:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888093006/40001
11 months ago (2017-05-24 16:49:52 UTC) #14
commit-bot: I haz the power
11 months ago (2017-05-24 18:35:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/12be8ae4eb156601cc7e26e41199...

Powered by Google App Engine
This is Rietveld 408576698