[heap] Add GN flag for enabling concurrent marking.

[heap] Add GN flag for enabling concurrent marking.

BUG=chromium:723600
Review-Url: https://codereview.chromium.org/2888093003
Cr-Commit-Position: refs/heads/master@{#45379}
Committed: https://chromium.googlesource.com/v8/v8/+/f1e82a2ee9d339f86b47cd4507c0a58f9c06e608

[ulan, 2017-05-17 12:46:41]

ulan@chromium.org changed reviewers:
+ machenbach@chromium.org, mlippautz@chromium.org

[ulan, 2017-05-17 12:46:42]

ptal

[Michael Achenbach, 2017-05-17 14:14:44]

https://codereview.chromium.org/2888093003/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2888093003/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:672: DEFINE_BOOL(concurrent_marking, false, "use
concurrent marking")
why not keep it on by default, like e.g. line 452? Then we avoid passing it
around in the infrastructure...

[ulan, 2017-05-17 14:34:48]

https://codereview.chromium.org/2888093003/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2888093003/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:672: DEFINE_BOOL(concurrent_marking, false, "use
concurrent marking")
On 2017/05/17 14:14:44, Michael Achenbach wrote:
> why not keep it on by default, like e.g. line 452? Then we avoid passing it
> around in the infrastructure...

Good idea. Done.

[Michael Lippautz, 2017-05-17 14:36:36]

lgtm

[ulan, 2017-05-17 14:42:09]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2017-05-17 14:42:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 15:22:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495032129827760,
"parent_rev": "1be27497bab70345837bf007ccc6f3349d76308f", "commit_rev":
"f1e82a2ee9d339f86b47cd4507c0a58f9c06e608"}

[commit-bot: I haz the power, 2017-05-17 15:22:45]

Description was changed from

==========
[heap] Add GN flag for enabling concurrent marking.

BUG=chromium:723600
==========

to

==========
[heap] Add GN flag for enabling concurrent marking.

BUG=chromium:723600

Review-Url: https://codereview.chromium.org/2888093003
Cr-Commit-Position: refs/heads/master@{#45379}
Committed:
https://chromium.googlesource.com/v8/v8/+/f1e82a2ee9d339f86b47cd4507c0a58f9c0...
==========

[commit-bot: I haz the power, 2017-05-17 15:22:46]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/f1e82a2ee9d339f86b47cd4507c0a58f9c0...