chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc - Issue 2888073002: Remove raw DictionaryValue::Set in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)

Patch Set: Fix Tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/prerender/prerender_history.h ('K') | « chrome/common/extensions/api/common_extension_api_unittest.cc ('k') | chrome/common/extensions/command_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

diff --git a/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc b/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

index 8bbcc5b977c8fd468b6901c50feb83799a8146a4..f8b9fab0ba4106b963e2e40a4296e4bc987558e6 100644

--- a/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

+++ b/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

@@ -10,6 +10,7 @@

#include "base/files/file_path.h"

#include "base/files/file_util.h"

#include "base/files/scoped_temp_dir.h"

+#include "base/memory/ptr_util.h"

#include "base/values.h"

#include "components/version_info/version_info.h"

#include "extensions/common/extension.h"

@@ -88,7 +89,7 @@ TEST_F(StorageSchemaManifestHandlerTest, Parse) {

TEST_F(StorageSchemaManifestHandlerTest, Validate) {

base::ListValue permissions;

permissions.AppendString("storage");

- manifest_.Set("permissions", permissions.DeepCopy());

+ manifest_.Set("permissions", base::MakeUnique<base::Value>(permissions));

// Absolute path.

manifest_.SetString("storage.managed_schema", "/etc/passwd");