Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6045)

Unified Diff: chrome/browser/supervised_user/supervised_user_whitelist_service_unittest.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/supervised_user_whitelist_service_unittest.cc
diff --git a/chrome/browser/supervised_user/supervised_user_whitelist_service_unittest.cc b/chrome/browser/supervised_user/supervised_user_whitelist_service_unittest.cc
index 26af703a17f996ed2cfc89e87f5ace79b8fc9345..2829bf66587d4a3b0358eac596f22834f77adfb1 100644
--- a/chrome/browser/supervised_user/supervised_user_whitelist_service_unittest.cc
+++ b/chrome/browser/supervised_user/supervised_user_whitelist_service_unittest.cc
@@ -8,6 +8,7 @@
#include <memory>
#include <set>
#include <string>
+#include <utility>
#include "base/bind.h"
#include "base/callback.h"
@@ -110,11 +111,11 @@ class SupervisedUserWhitelistServiceTest : public testing::Test {
std::unique_ptr<base::DictionaryValue> whitelist_dict(
new base::DictionaryValue);
whitelist_dict->SetString("name", "Whitelist A");
- dict->Set("aaaa", whitelist_dict.release());
+ dict->Set("aaaa", std::move(whitelist_dict));
whitelist_dict.reset(new base::DictionaryValue);
whitelist_dict->SetString("name", "Whitelist B");
- dict->Set("bbbb", whitelist_dict.release());
+ dict->Set("bbbb", std::move(whitelist_dict));
installer_->RegisterWhitelist(kClientId, "aaaa", "Whitelist A");
installer_->RegisterWhitelist(kClientId, "bbbb", "Whitelist B");

Powered by Google App Engine
This is Rietveld 408576698