Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2719)

Unified Diff: chrome/browser/supervised_user/legacy/supervised_user_sync_service_unittest.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/legacy/supervised_user_sync_service_unittest.cc
diff --git a/chrome/browser/supervised_user/legacy/supervised_user_sync_service_unittest.cc b/chrome/browser/supervised_user/legacy/supervised_user_sync_service_unittest.cc
index 88a7e52007c5e17555cb109bdc232acbb87fed24..7053973410bb5c5556461e78ae3bccfb890ddd0a 100644
--- a/chrome/browser/supervised_user/legacy/supervised_user_sync_service_unittest.cc
+++ b/chrome/browser/supervised_user/legacy/supervised_user_sync_service_unittest.cc
@@ -5,11 +5,14 @@
#include <stdint.h>
#include <string>
+#include <utility>
#include "base/bind.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/threading/sequenced_worker_pool.h"
+#include "base/values.h"
#include "build/build_config.h"
#include "chrome/browser/supervised_user/legacy/supervised_user_sync_service.h"
#include "chrome/browser/supervised_user/legacy/supervised_user_sync_service_factory.h"
@@ -195,13 +198,13 @@ TEST_F(SupervisedUserSyncServiceTest, MergeExisting) {
{
DictionaryPrefUpdate update(prefs(), prefs::kSupervisedUsers);
base::DictionaryValue* supervised_users = update.Get();
- base::DictionaryValue* dict = new base::DictionaryValue;
+ auto dict = base::MakeUnique<base::DictionaryValue>();
dict->SetString(kNameKey, kName1);
- supervised_users->Set(kUserId1, dict);
- dict = new base::DictionaryValue;
+ supervised_users->Set(kUserId1, std::move(dict));
+ dict = base::MakeUnique<base::DictionaryValue>();
dict->SetString(kNameKey, kName2);
dict->SetBoolean(kAcknowledgedKey, true);
- supervised_users->Set(kUserId2, dict);
+ supervised_users->Set(kUserId2, std::move(dict));
}
const base::DictionaryValue* async_supervised_users = NULL;

Powered by Google App Engine
This is Rietveld 408576698