chrome/browser/profile_resetter/profile_resetter_unittest.cc - Issue 2888073002: Remove raw DictionaryValue::Set in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profile_resetter/profile_resetter_unittest.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)

Patch Set: Fix Tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/profile_resetter/profile_resetter_unittest.cc

diff --git a/chrome/browser/profile_resetter/profile_resetter_unittest.cc b/chrome/browser/profile_resetter/profile_resetter_unittest.cc

index d0d11a873b6a4efc808f305a3ba55a7478999487..5d2f931bc3b81c5b80fd6a4bdc7460a6ca08510c 100644

--- a/chrome/browser/profile_resetter/profile_resetter_unittest.cc

+++ b/chrome/browser/profile_resetter/profile_resetter_unittest.cc

@@ -387,7 +387,7 @@ scoped_refptr<Extension> CreateExtension(const base::string16& name,

switch (type) {

case extensions::Manifest::TYPE_THEME:

manifest.Set(extensions::manifest_keys::kTheme,

- new base::DictionaryValue);

+ base::MakeUnique<base::DictionaryValue>());

break;

case extensions::Manifest::TYPE_HOSTED_APP:

manifest.SetString(extensions::manifest_keys::kLaunchWebURL,