Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1636)

Unified Diff: chrome/browser/permissions/chooser_context_base.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/chooser_context_base.cc
diff --git a/chrome/browser/permissions/chooser_context_base.cc b/chrome/browser/permissions/chooser_context_base.cc
index 1214898c8b39f6663cc98437009b551179c40efe..4d566b192cc18d43b11c2904118ab330426caa45 100644
--- a/chrome/browser/permissions/chooser_context_base.cc
+++ b/chrome/browser/permissions/chooser_context_base.cc
@@ -113,8 +113,8 @@ void ChooserContextBase::GrantObjectPermission(
GetWebsiteSetting(requesting_origin, embedding_origin);
base::ListValue* object_list;
if (!setting->GetList(kObjectListKey, &object_list)) {
- object_list = new base::ListValue();
- setting->Set(kObjectListKey, object_list);
+ object_list =
+ setting->SetList(kObjectListKey, base::MakeUnique<base::ListValue>());
}
object_list->AppendIfNotPresent(std::move(object));
SetWebsiteSetting(requesting_origin, embedding_origin, std::move(setting));

Powered by Google App Engine
This is Rietveld 408576698