Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: chrome/browser/extensions/api/proxy/proxy_api.cc

Issue 2888073002: Remove raw DictionaryValue::Set in //chrome (Closed)
Patch Set: Fix Tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/proxy/proxy_api.cc
diff --git a/chrome/browser/extensions/api/proxy/proxy_api.cc b/chrome/browser/extensions/api/proxy/proxy_api.cc
index 4116d9f4f8e62e3409d4fd62ecd4f4547f1a526d..a234547343c1ff429920769ae8bdf04ea0ee7d97 100644
--- a/chrome/browser/extensions/api/proxy/proxy_api.cc
+++ b/chrome/browser/extensions/api/proxy/proxy_api.cc
@@ -171,19 +171,20 @@ std::unique_ptr<base::Value> ProxyPrefTransformer::BrowserToExtensionPref(
// A PAC URL either point to a PAC script or contain a base64 encoded
// PAC script. In either case we build a PacScript dictionary as defined
// in the extension API.
- base::DictionaryValue* pac_dict = helpers::CreatePacScriptDict(config);
+ std::unique_ptr<base::DictionaryValue> pac_dict =
+ helpers::CreatePacScriptDict(config);
if (!pac_dict)
return nullptr;
- extension_pref->Set(keys::kProxyConfigPacScript, pac_dict);
+ extension_pref->Set(keys::kProxyConfigPacScript, std::move(pac_dict));
break;
}
case ProxyPrefs::MODE_FIXED_SERVERS: {
// Build ProxyRules dictionary according to the extension API.
- base::DictionaryValue* proxy_rules_dict =
+ std::unique_ptr<base::DictionaryValue> proxy_rules_dict =
helpers::CreateProxyRulesDict(config);
if (!proxy_rules_dict)
return nullptr;
- extension_pref->Set(keys::kProxyConfigRules, proxy_rules_dict);
+ extension_pref->Set(keys::kProxyConfigRules, std::move(proxy_rules_dict));
break;
}
case ProxyPrefs::kModeCount:

Powered by Google App Engine
This is Rietveld 408576698