Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2888053002: Rename TaskRunner::RunsTasksOnCurrentThread() in //extensions, //headless, //mojo (Closed)

Created:
3 years, 7 months ago by Yeol Park
Modified:
3 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, chromium-apps-reviews_chromium.org, darin (slow to review), stevenjb+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename TaskRunner::RunsTasksOnCurrentThread() in //extensions, //headless, //mojo renamed TaskRunner::RunsTasksOnCurrentThread() to TaskRunner::RunsTasksInCurrentSequence() in //extensions, //headless, //mojo Additionally, used TaskScheduler instead of blocking pool in storage_info_provider.cc referenced to crbug.com/667892. The blocking pool is being deprecated in favor of TaskScheduler. BUG=665062 Review-Url: https://codereview.chromium.org/2888053002 Cr-Commit-Position: refs/heads/master@{#473802} Committed: https://chromium.googlesource.com/chromium/src/+/61491c6487631e3a949dbcdb55e8309f4d18998d

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -55 lines) Patch
M extensions/browser/api/networking_private/networking_private_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/system_storage/storage_info_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/sandboxed_unpacker.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M headless/public/util/generic_url_request_job.cc View 1 10 chunks +11 lines, -11 lines 0 comments Download
M mojo/edk/system/channel_posix.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/channel_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/node_channel.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/node_controller.cc View 1 16 chunks +16 lines, -16 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_endpoint_client.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/thread_safe_interface_ptr.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/system/simple_watcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (21 generated)
Yeol Park
PTAL :) rdevlin.cronin@ for extensions/* skyostil@ for headless/* ben@ for mojo/*
3 years, 7 months ago (2017-05-17 05:44:45 UTC) #3
Sami
headless/ lgtm.
3 years, 7 months ago (2017-05-17 13:08:43 UTC) #4
Devlin
extensions lgtm https://codereview.chromium.org/2888053002/diff/1/extensions/browser/api/system_storage/storage_info_provider.cc File extensions/browser/api/system_storage/storage_info_provider.cc (right): https://codereview.chromium.org/2888053002/diff/1/extensions/browser/api/system_storage/storage_info_provider.cc#newcode71 extensions/browser/api/system_storage/storage_info_provider.cc:71: base::ThreadRestrictions::AssertIOAllowed(); Might be worth mentioning this change ...
3 years, 7 months ago (2017-05-17 15:06:23 UTC) #7
Yeol Park
PTAL :) +jam@ for //mojo
3 years, 7 months ago (2017-05-19 02:24:01 UTC) #13
Yeol Park
https://codereview.chromium.org/2888053002/diff/1/extensions/browser/api/system_storage/storage_info_provider.cc File extensions/browser/api/system_storage/storage_info_provider.cc (right): https://codereview.chromium.org/2888053002/diff/1/extensions/browser/api/system_storage/storage_info_provider.cc#newcode71 extensions/browser/api/system_storage/storage_info_provider.cc:71: base::ThreadRestrictions::AssertIOAllowed(); On 2017/05/17 15:06:23, Devlin (catching up) wrote: > ...
3 years, 7 months ago (2017-05-19 07:31:36 UTC) #14
jam
lgtm
3 years, 7 months ago (2017-05-22 22:40:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888053002/20001
3 years, 7 months ago (2017-05-23 03:34:38 UTC) #26
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 03:39:39 UTC) #29
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/61491c6487631e3a949dbcdb55e8...

Powered by Google App Engine
This is Rietveld 408576698