Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2888043007: Revert of Reland Replace AudioFifo with a deque of AudioBus in ATR::AudioEncoder (Closed)

Created:
3 years, 7 months ago by jbroman
Modified:
3 years, 7 months ago
Reviewers:
mcasas, miu, Chandan
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, emircan+watch+mediarecorder_chromium.org, mcasas+mediarecorder_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland Replace AudioFifo with a deque of AudioBus in ATR::AudioEncoder (patchset #2 id:20001 of https://codereview.chromium.org/2881713002/ ) Reason for revert: Suspected of causing content_unittests MediaRecorderHandlerTest.EncodeAudioFrames/2 to fail on Windows: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/60080 Original issue's description: > Reland Replace AudioFifo with a deque of AudioBus in ATR::AudioEncoder > > Link to original CL: https://codereview.chromium.org/2854363002/ > > Original CL description: > This CL uses a std::deque<std::unique_ptr<media::AudioBus>> instead > of an AudioFifo, to avoid copying data needlessly. > > The original CL was reverted due to failures in the build cycles as shown on: > https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzY3OGM3NGNmM2UxN2FhZWY5NTYyZWUxM2RmOGM4MDNlMWQwMTRmYzYM > > The failure was caused as uninitialized memory was being read. > > This reland CL zeroes out all channels of incoming audio bus if the deque is empty. > > BUG=None > > Review-Url: https://codereview.chromium.org/2881713002 > Cr-Commit-Position: refs/heads/master@{#472836} > Committed: https://chromium.googlesource.com/chromium/src/+/8e3f09678fd2199649fdfde1bb9cc0ec55240309 TBR=mcasas@chromium.org,miu@chromium.org,c.padhi@samsung.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2888043007 Cr-Commit-Position: refs/heads/master@{#472906} Committed: https://chromium.googlesource.com/chromium/src/+/cb5adebb5e8db8146d7ad2fb5a8c6219561ae28c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -27 lines) Patch
M content/renderer/media_recorder/audio_track_recorder.cc View 8 chunks +13 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jbroman
Created Revert of Reland Replace AudioFifo with a deque of AudioBus in ATR::AudioEncoder
3 years, 7 months ago (2017-05-18 19:41:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888043007/1
3 years, 7 months ago (2017-05-18 19:42:45 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 19:43:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cb5adebb5e8db8146d7ad2fb5a8c...

Powered by Google App Engine
This is Rietveld 408576698