Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1962)

Unified Diff: content/renderer/gpu/renderer_compositor_frame_sink.cc

Issue 2888043004: [cc] Add and plumb CFS::DidNotProduceFrame. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/renderer_compositor_frame_sink.cc
diff --git a/content/renderer/gpu/renderer_compositor_frame_sink.cc b/content/renderer/gpu/renderer_compositor_frame_sink.cc
index f06784c42a312865cc027ea7ac8d7d73b27e29d7..48c5f4c1c00a9826cf1953d38bf639ebb6e4cb22 100644
--- a/content/renderer/gpu/renderer_compositor_frame_sink.cc
+++ b/content/renderer/gpu/renderer_compositor_frame_sink.cc
@@ -123,6 +123,7 @@ void RendererCompositorFrameSink::DetachFromClient() {
void RendererCompositorFrameSink::SubmitCompositorFrame(
cc::CompositorFrame frame) {
// We should only submit CompositorFrames with valid BeginFrameAcks.
+ DCHECK(frame.metadata.begin_frame_ack.has_damage);
DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber,
frame.metadata.begin_frame_ack.sequence_number);
if (ShouldAllocateNewLocalSurfaceId(frame))
@@ -150,6 +151,13 @@ void RendererCompositorFrameSink::SubmitCompositorFrame(
}
}
+void RendererCompositorFrameSink::BeginFrameDidNotProduceFrame(
+ const cc::BeginFrameAck& ack) {
+ DCHECK(!ack.has_damage);
+ DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber, ack.sequence_number);
+ sink_->BeginFrameDidNotProduceFrame(ack);
+}
+
void RendererCompositorFrameSink::OnMessageReceived(
const IPC::Message& message) {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -232,12 +240,7 @@ void RendererCompositorFrameSink::OnNeedsBeginFrames(bool needs_begin_frames) {
}
void RendererCompositorFrameSink::OnDidFinishFrame(
- const cc::BeginFrameAck& ack) {
- DCHECK_LE(cc::BeginFrameArgs::kStartingFrameNumber, ack.sequence_number);
- // If there was damage, ViewHostMsg_SwapCompositorFrame includes the ack.
- if (!ack.has_damage)
- sink_->BeginFrameDidNotSwap(ack);
-}
+ const cc::BeginFrameAck& ack) {}
void RendererCompositorFrameSink::EstablishMojoConnection() {
cc::mojom::MojoCompositorFrameSinkPtr sink;

Powered by Google App Engine
This is Rietveld 408576698