Devices shoule not be found by Android enrollment app after successful enrollment.

Devices shoule not be found by Android enrollment app after successful enrollment.

Changes in this cl,
1. Remove SetName() in BluetoothHostPairingController. The name of the 
Apapter has been set in BluetoothAdapterBlueZ::Init().
2. Add UUID filter for device discovery when automatically 
enrollment. This will make sure the device can only be found during OOBE. 
It will not be found by the Android enrollment app after login if the 
user set the device as discover-able manually. 

BUG=720774
Review-Url: https://codereview.chromium.org/2888033002
Cr-Commit-Position: refs/heads/master@{#474487}
Committed: https://chromium.googlesource.com/chromium/src/+/6872d3f67f6b70462aedcd20417c8ab31455f12c

[minch1, 2017-05-17 01:16:59]

The CQ bit was checked by minch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 01:17:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 03:24:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 03:24:10]

Dry run: This issue passed the CQ dry run.

[minch1, 2017-05-17 16:42:55]

Description was changed from

==========
Devices shoule not be found by Android enrollment app after successful
enrollment.

BUG=720774
==========

to

==========
Devices shoule not be found by Android enrollment app after successful
enrollment.

BUG=720774
==========

[minch1, 2017-05-17 16:42:55]

minch@chromium.org changed reviewers:
+ xdai@chromium.org, zork@chromium.org

[minch1, 2017-05-17 16:43:58]

Hi, zork@ and xdai@, could you help review? Thanks.

[zork, 2017-05-17 16:59:06]

zork@google.com changed reviewers:
+ zork@google.com

[zork, 2017-05-17 16:59:07]

We should update the function name to reflect the new behavior, then LGTM

https://codereview.chromium.org/2888033002/diff/1/components/pairing/bluetoot...
File components/pairing/bluetooth_host_pairing_controller.cc (right):

https://codereview.chromium.org/2888033002/diff/1/components/pairing/bluetoot...
components/pairing/bluetooth_host_pairing_controller.cc:197: void
BluetoothHostPairingController::SetName() {
I think a better name for this function would be "UpdateAdapterName"

[xdai1, 2017-05-17 17:46:51]

https://codereview.chromium.org/2888033002/diff/1/components/pairing/bluetoot...
File components/pairing/bluetooth_host_pairing_controller.cc (right):

https://codereview.chromium.org/2888033002/diff/1/components/pairing/bluetoot...
components/pairing/bluetooth_host_pairing_controller.cc:202: if (current_stage_
== STAGE_FINISHED) {
Per offline discussion, I would suggest to have a previous_device_name_ variable
to record the previous device name before Bootstrapping process and reset to
previous_device_name_ after Bootstrapping process. This way we won't
accidentally change the device name if someone else has changed the device's
name before the Bootstrapping process.

https://codereview.chromium.org/2888033002/diff/1/components/pairing/bluetoot...
components/pairing/bluetooth_host_pairing_controller.cc:442: SetName();
I think you should reset Bluetooth name for both success enrollment case and all
error cases. (for example, the Bootstrapping failed at network configuring stage
and then later the user decided to do a manual enrollment, we need to make sure
the Chrome OS device Bluetooth device is consistent under all cases.)

[minch1, 2017-05-19 17:23:11]

The CQ bit was checked by minch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 17:23:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 18:04:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 18:04:04]

Dry run: This issue passed the CQ dry run.

[minch1, 2017-05-19 21:15:50]

The CQ bit was checked by minch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 21:17:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[minch1, 2017-05-19 21:19:52]

The CQ bit was checked by minch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 21:20:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 21:36:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 21:36:57]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[minch1, 2017-05-20 03:06:55]

The CQ bit was checked by minch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-20 03:07:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-20 03:53:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-20 03:53:40]

Dry run: This issue passed the CQ dry run.

[minch1, 2017-05-22 17:11:56]

minch@chromium.org changed reviewers:
- zork@chromium.org

[minch1, 2017-05-22 17:11:58]

xdai@, zork@, could you help review? Thanks.

[xdai1, 2017-05-22 18:19:09]

On 2017/05/22 17:11:58, minch1 wrote:
> xdai@, zork@, could you help review? Thanks.

lgtm 
Please update the CL description to better describe what you did in this CL.

[minch1, 2017-05-22 18:52:32]

Description was changed from

==========
Devices shoule not be found by Android enrollment app after successful
enrollment.

BUG=720774
==========

to

==========
Devices shoule not be found by Android enrollment app after successful
enrollment.

Changes in this cl,
1. Remove SetName() in BluetoothHostPairingController. The name of the 
Apapter has been set in BluetoothAdapterBlueZ::Init().
2. Add UUID filter for device discovery during automatically enrollment.
This will make sure the device can only be found during OOBE. It will
not be found by the Android enrollment app after login if the user
set the device as discover-able manually. 

BUG=720774
==========

[minch1, 2017-05-22 18:53:33]

Description was changed from

==========
Devices shoule not be found by Android enrollment app after successful
enrollment.

Changes in this cl,
1. Remove SetName() in BluetoothHostPairingController. The name of the 
Apapter has been set in BluetoothAdapterBlueZ::Init().
2. Add UUID filter for device discovery during automatically enrollment.
This will make sure the device can only be found during OOBE. It will
not be found by the Android enrollment app after login if the user
set the device as discover-able manually. 

BUG=720774
==========

to

==========
Devices shoule not be found by Android enrollment app after successful
enrollment.

Changes in this cl,
1. Remove SetName() in BluetoothHostPairingController. The name of the 
Apapter has been set in BluetoothAdapterBlueZ::Init().
2. Add UUID filter for device discovery when automatically 
enrollment.This will make sure the device can only be found during OOBE. It will
not be found by the Android enrollment app after login if the user
set the device as discover-able manually. 

BUG=720774
==========

[minch1, 2017-05-22 18:54:11]

Description was changed from

==========
Devices shoule not be found by Android enrollment app after successful
enrollment.

Changes in this cl,
1. Remove SetName() in BluetoothHostPairingController. The name of the 
Apapter has been set in BluetoothAdapterBlueZ::Init().
2. Add UUID filter for device discovery when automatically 
enrollment.This will make sure the device can only be found during OOBE. It will
not be found by the Android enrollment app after login if the user
set the device as discover-able manually. 

BUG=720774
==========

to

==========
Devices shoule not be found by Android enrollment app after successful
enrollment.

Changes in this cl,
1. Remove SetName() in BluetoothHostPairingController. The name of the 
Apapter has been set in BluetoothAdapterBlueZ::Init().
2. Add UUID filter for device discovery when automatically 
enrollment.This will make sure the device can only be found during OOBE. 
It will not be found by the Android enrollment app after login if the user
set the device as discover-able manually. 

BUG=720774
==========

[minch1, 2017-05-22 18:54:52]

Description was changed from

==========
Devices shoule not be found by Android enrollment app after successful
enrollment.

Changes in this cl,
1. Remove SetName() in BluetoothHostPairingController. The name of the 
Apapter has been set in BluetoothAdapterBlueZ::Init().
2. Add UUID filter for device discovery when automatically 
enrollment.This will make sure the device can only be found during OOBE. 
It will not be found by the Android enrollment app after login if the user
set the device as discover-able manually. 

BUG=720774
==========

to

==========
Devices shoule not be found by Android enrollment app after successful
enrollment.

Changes in this cl,
1. Remove SetName() in BluetoothHostPairingController. The name of the 
Apapter has been set in BluetoothAdapterBlueZ::Init().
2. Add UUID filter for device discovery when automatically 
enrollment. This will make sure the device can only be found during OOBE. 
It will not be found by the Android enrollment app after login if the 
user set the device as discover-able manually. 

BUG=720774
==========

[minch1, 2017-05-23 16:17:01]

minch@chromium.org changed reviewers:
+ zork@chromium.org
- zork@google.com

[Zachary Kuznia, 2017-05-24 23:30:16]

lgtm

[minch1, 2017-05-24 23:46:42]

The CQ bit was checked by minch@chromium.org

[minch1, 2017-05-24 23:46:42]

The patchset sent to the CQ was uploaded after l-g-t-m from zork@google.com
Link to the patchset: https://codereview.chromium.org/2888033002/#ps80001
(title: "Add UUID as filter when detecting devices.")

[commit-bot: I haz the power, 2017-05-24 23:47:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 00:20:36]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495669602298620,
"parent_rev": "617dcc23c266b0b3c50fdb58052fdc6818e6b06b", "commit_rev":
"6872d3f67f6b70462aedcd20417c8ab31455f12c"}

[commit-bot: I haz the power, 2017-05-25 00:20:50]

Description was changed from

==========
Devices shoule not be found by Android enrollment app after successful
enrollment.

Changes in this cl,
1. Remove SetName() in BluetoothHostPairingController. The name of the 
Apapter has been set in BluetoothAdapterBlueZ::Init().
2. Add UUID filter for device discovery when automatically 
enrollment. This will make sure the device can only be found during OOBE. 
It will not be found by the Android enrollment app after login if the 
user set the device as discover-able manually. 

BUG=720774
==========

to

==========
Devices shoule not be found by Android enrollment app after successful
enrollment.

Changes in this cl,
1. Remove SetName() in BluetoothHostPairingController. The name of the 
Apapter has been set in BluetoothAdapterBlueZ::Init().
2. Add UUID filter for device discovery when automatically 
enrollment. This will make sure the device can only be found during OOBE. 
It will not be found by the Android enrollment app after login if the 
user set the device as discover-able manually. 

BUG=720774

Review-Url: https://codereview.chromium.org/2888033002
Cr-Commit-Position: refs/heads/master@{#474487}
Committed:
https://chromium.googlesource.com/chromium/src/+/6872d3f67f6b70462aedcd20417c...
==========

[commit-bot: I haz the power, 2017-05-25 00:20:51]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/6872d3f67f6b70462aedcd20417c...