chromeos: Remove some WmWindow usage from ash/system

chromeos: Remove some WmWindow usage from ash/system

It's left over from the early mustash days and we don't need it anymore.

BUG=722552
TEST=ash_unittests, manually open/close system tray, change volume, etc.

Review-Url: https://codereview.chromium.org/2888013002
Cr-Commit-Position: refs/heads/master@{#472477}
Committed: https://chromium.googlesource.com/chromium/src/+/e21aa45368ae7b37e47ce08d880062834d295693

[James Cook, 2017-05-16 22:43:50]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2017-05-16 22:44:43]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2017-05-16 22:44:44]

sky, please take a look.

https://codereview.chromium.org/2888013002/diff/20001/ash/system/audio/tray_a...
File ash/system/audio/tray_audio.cc (right):

https://codereview.chromium.org/2888013002/diff/20001/ash/system/audio/tray_a...
ash/system/audio/tray_audio.cc:47: for (RootWindowController* root :
Shell::GetAllRootWindowControllers()) {
Do we prefer this, RootWindowController::root_window_controllers(), or
ShellPort::Get()->GetAllRootWindows() and lookup each RWC?

[commit-bot: I haz the power, 2017-05-16 22:45:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 00:30:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 00:30:06]

Dry run: This issue passed the CQ dry run.

[sky, 2017-05-17 16:12:40]

LGTM

https://codereview.chromium.org/2888013002/diff/20001/ash/system/audio/tray_a...
File ash/system/audio/tray_audio.cc (right):

https://codereview.chromium.org/2888013002/diff/20001/ash/system/audio/tray_a...
ash/system/audio/tray_audio.cc:47: for (RootWindowController* root :
Shell::GetAllRootWindowControllers()) {
On 2017/05/16 22:44:44, James Cook wrote:
> Do we prefer this, RootWindowController::root_window_controllers(), or
> ShellPort::Get()->GetAllRootWindows() and lookup each RWC?

I would like to move to where ShellPort usage is very minimal, and in fact once
I get mash using simplified display management we can get rid of the static
functions that you mention. In other words, what you hae here is great!

[James Cook, 2017-05-17 16:20:25]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-05-17 16:21:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 16:38:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495038025880920,
"parent_rev": "7cff6e53f9e6fec407271cc49ace0b33a9f07021", "commit_rev":
"e21aa45368ae7b37e47ce08d880062834d295693"}

[commit-bot: I haz the power, 2017-05-17 16:38:25]

Description was changed from

==========
chromeos: Remove some WmWindow usage from ash/system

It's left over from the early mustash days and we don't need it anymore.

BUG=722552
TEST=ash_unittests, manually open/close system tray, change volume, etc.
==========

to

==========
chromeos: Remove some WmWindow usage from ash/system

It's left over from the early mustash days and we don't need it anymore.

BUG=722552
TEST=ash_unittests, manually open/close system tray, change volume, etc.

Review-Url: https://codereview.chromium.org/2888013002
Cr-Commit-Position: refs/heads/master@{#472477}
Committed:
https://chromium.googlesource.com/chromium/src/+/e21aa45368ae7b37e47ce08d8800...
==========

[commit-bot: I haz the power, 2017-05-17 16:38:26]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e21aa45368ae7b37e47ce08d8800...