Settings: Network: Fix flex layout

Settings: Network: Fix flex layout

BUG=720024
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2888003002
Cr-Commit-Position: refs/heads/master@{#472571}
Committed: https://chromium.googlesource.com/chromium/src/+/b9d45fd1e8df311199e407e332ca12655d8c8e36

[stevenjb, 2017-05-16 21:54:35]

Description was changed from

==========
Settings: Network: Fix flex layout

BUG=720024
==========

to

==========
Settings: Network: Fix flex layout

BUG=720024
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-05-16 21:55:53]

stevenjb@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dschuyler, 2017-05-16 23:19:53]

If removing the iron-flex-layout-classes.html is a bother, it can be done later
(maybe by me or someone else). If it's easy to remove now, that would be good.
Just let me know.

https://codereview.chromium.org/2888003002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/network_proxy.html (right):

https://codereview.chromium.org/2888003002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/network_proxy.html:55: <div
class="layout horizontal center">
Will .settings-row work here in place of "layout horizontal center" (and avoid
importing the extra iron-flex-layout-classes.html).

https://codereview.chromium.org/2888003002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/network_proxy.html:137: <div
hidden$="[[!useSameProxy_]]" class="layout vertical">
.single-column may work in place of "layout vertical".

[stevenjb, 2017-05-16 23:35:05]

I have been trying (and occasionally succeeding) to reduce dependencies on flex
layout. That said, 'iron-flex' is pretty small and readable.

https://codereview.chromium.org/2888003002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/internet_page/network_proxy.html (right):

https://codereview.chromium.org/2888003002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/network_proxy.html:55: <div
class="layout horizontal center">
On 2017/05/16 23:19:53, dschuyler wrote:
> Will .settings-row work here in place of "layout horizontal center" (and avoid
> importing the extra iron-flex-layout-classes.html).

Not exactly. It adds some other stuff that doesn't quite work right here.
Network layout is kind of unique.

https://codereview.chromium.org/2888003002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/internet_page/network_proxy.html:137: <div
hidden$="[[!useSameProxy_]]" class="layout vertical">
On 2017/05/16 23:19:53, dschuyler wrote:
> .single-column may work in place of "layout vertical".

Again, that also sets a couple of extra properties that I'm not sure about.

[dschuyler, 2017-05-16 23:36:27]

Thank you for looking into that. ltgm.

[dschuyler, 2017-05-16 23:44:28]

On 2017/05/16 23:36:27, dschuyler wrote:
> Thank you for looking into that. ltgm.

Or lgtm.

[stevenjb, 2017-05-17 17:12:37]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-05-17 17:14:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 19:49:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 19:49:06]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2017-05-17 19:50:47]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-05-17 19:52:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 21:14:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495050647790820, "parent_rev":
"a3aab87dee219020085ed7ae8f84993c3cecef17", "commit_rev":
"b9d45fd1e8df311199e407e332ca12655d8c8e36"}

[commit-bot: I haz the power, 2017-05-17 21:15:09]

Description was changed from

==========
Settings: Network: Fix flex layout

BUG=720024
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings: Network: Fix flex layout

BUG=720024
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2888003002
Cr-Commit-Position: refs/heads/master@{#472571}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9d45fd1e8df311199e407e332ca...
==========

[commit-bot: I haz the power, 2017-05-17 21:15:12]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b9d45fd1e8df311199e407e332ca...