Leave client certificate combobox empty if managed certficate not found

Leave client certificate combobox empty if managed certficate not found

If the client certificate is managed by ONC user or device policy, and
the policy-specified certifcate (e.g. in a certificate pattern) is not
found, the combobox displaying the selected certificate should be empty.
Before this change, the first certificte was displayed instead. This was
misleading, because the first certificate is not the policy-set
certificate, and it is not possible to connect to the network in this
state.
Note that the user can't change the certificate in this case (because
it's managed by policy).

BUG=655266
TEST=Manual test

Review-Url: https://codereview.chromium.org/2887993003
Cr-Commit-Position: refs/heads/master@{#472787}
Committed: https://chromium.googlesource.com/chromium/src/+/5268d0272446b745d2d7299a73c133d63e08a6b5

[pmarko, 2017-05-17 14:43:42]

pmarko@chromium.org changed reviewers:
+ xiyuan@chromium.org

[pmarko, 2017-05-17 14:43:42]

xiyuan, PTAL.

[xiyuan, 2017-05-17 18:17:09]

lgtm

https://codereview.chromium.org/2887993003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/options/wifi_config_view.h (right):

https://codereview.chromium.org/2887993003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/options/wifi_config_view.h:220: bool
managed_user_cert_not_found_;
nit: initialize it to false here.

i.e.
  bool managed_user_cert_not_found_ = false;

[pmarko, 2017-05-18 12:17:44]

https://codereview.chromium.org/2887993003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/options/wifi_config_view.h (right):

https://codereview.chromium.org/2887993003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/options/wifi_config_view.h:220: bool
managed_user_cert_not_found_;
On 2017/05/17 18:17:09, xiyuan wrote:
> nit: initialize it to false here.
> 
> i.e.
>   bool managed_user_cert_not_found_ = false;

Done.

[pmarko, 2017-05-18 12:17:48]

The CQ bit was checked by pmarko@chromium.org

[pmarko, 2017-05-18 12:17:48]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2887993003/#ps60001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2017-05-18 12:18:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 13:16:02]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495109868365840,
"parent_rev": "f5a564cc28633d8f086f057c1cf7fd58222fb2d4", "commit_rev":
"5268d0272446b745d2d7299a73c133d63e08a6b5"}

[commit-bot: I haz the power, 2017-05-18 13:16:15]

Description was changed from

==========
Leave client certificate combobox empty if managed certficate not found

If the client certificate is managed by ONC user or device policy, and
the policy-specified certifcate (e.g. in a certificate pattern) is not
found, the combobox displaying the selected certificate should be empty.
Before this change, the first certificte was displayed instead. This was
misleading, because the first certificate is not the policy-set
certificate, and it is not possible to connect to the network in this
state.
Note that the user can't change the certificate in this case (because
it's managed by policy).

BUG=655266
TEST=Manual test
==========

to

==========
Leave client certificate combobox empty if managed certficate not found

If the client certificate is managed by ONC user or device policy, and
the policy-specified certifcate (e.g. in a certificate pattern) is not
found, the combobox displaying the selected certificate should be empty.
Before this change, the first certificte was displayed instead. This was
misleading, because the first certificate is not the policy-set
certificate, and it is not possible to connect to the network in this
state.
Note that the user can't change the certificate in this case (because
it's managed by policy).

BUG=655266
TEST=Manual test

Review-Url: https://codereview.chromium.org/2887993003
Cr-Commit-Position: refs/heads/master@{#472787}
Committed:
https://chromium.googlesource.com/chromium/src/+/5268d0272446b745d2d7299a73c1...
==========

[commit-bot: I haz the power, 2017-05-18 13:16:16]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5268d0272446b745d2d7299a73c1...