content/renderer/browser_plugin/browser_plugin.cc - Issue 2887973002: Fix an IME regression for <webview> due to missing IPC message param

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin.cc

Issue 2887973002: Fix an IME regression for <webview> due to missing IPC message param (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/browser_plugin/browser_plugin.cc

diff --git a/content/renderer/browser_plugin/browser_plugin.cc b/content/renderer/browser_plugin/browser_plugin.cc

index 8f14c29aa7071f9d0ac0a45d1755cd409e5cb5ea..9838606d7d0f25a06cd12ac9f540330b03132aa8 100644

--- a/content/renderer/browser_plugin/browser_plugin.cc

+++ b/content/renderer/browser_plugin/browser_plugin.cc

@@ -602,7 +602,8 @@ bool BrowserPlugin::FinishComposingText(

bool keep_selection =

(selection_behavior == blink::WebInputMethodController::kKeepSelection);

BrowserPluginManager::Get()->Send(

- new BrowserPluginHostMsg_ImeFinishComposingText(keep_selection));

+ new BrowserPluginHostMsg_ImeFinishComposingText(

+ browser_plugin_instance_id_, keep_selection));

// TODO(kochi): This assumes the IPC handling always succeeds.

return true;

}