Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: content/renderer/browser_plugin/browser_plugin.cc

Issue 2887973002: Fix an IME regression for <webview> due to missing IPC message param (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/browser_plugin/browser_plugin.h" 5 #include "content/renderer/browser_plugin/browser_plugin.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 584 matching lines...) Expand 10 before | Expand all | Expand 10 after
595 } 595 }
596 596
597 bool BrowserPlugin::FinishComposingText( 597 bool BrowserPlugin::FinishComposingText(
598 blink::WebInputMethodController::ConfirmCompositionBehavior 598 blink::WebInputMethodController::ConfirmCompositionBehavior
599 selection_behavior) { 599 selection_behavior) {
600 if (!attached()) 600 if (!attached())
601 return false; 601 return false;
602 bool keep_selection = 602 bool keep_selection =
603 (selection_behavior == blink::WebInputMethodController::kKeepSelection); 603 (selection_behavior == blink::WebInputMethodController::kKeepSelection);
604 BrowserPluginManager::Get()->Send( 604 BrowserPluginManager::Get()->Send(
605 new BrowserPluginHostMsg_ImeFinishComposingText(keep_selection)); 605 new BrowserPluginHostMsg_ImeFinishComposingText(
606 browser_plugin_instance_id_, keep_selection));
606 // TODO(kochi): This assumes the IPC handling always succeeds. 607 // TODO(kochi): This assumes the IPC handling always succeeds.
607 return true; 608 return true;
608 } 609 }
609 610
610 void BrowserPlugin::ExtendSelectionAndDelete(int before, int after) { 611 void BrowserPlugin::ExtendSelectionAndDelete(int before, int after) {
611 if (!attached()) 612 if (!attached())
612 return; 613 return;
613 BrowserPluginManager::Get()->Send( 614 BrowserPluginManager::Get()->Send(
614 new BrowserPluginHostMsg_ExtendSelectionAndDelete( 615 new BrowserPluginHostMsg_ExtendSelectionAndDelete(
615 browser_plugin_instance_id_, 616 browser_plugin_instance_id_,
(...skipping 16 matching lines...) Expand all
632 633
633 bool BrowserPlugin::HandleMouseLockedInputEvent( 634 bool BrowserPlugin::HandleMouseLockedInputEvent(
634 const blink::WebMouseEvent& event) { 635 const blink::WebMouseEvent& event) {
635 BrowserPluginManager::Get()->Send( 636 BrowserPluginManager::Get()->Send(
636 new BrowserPluginHostMsg_HandleInputEvent(browser_plugin_instance_id_, 637 new BrowserPluginHostMsg_HandleInputEvent(browser_plugin_instance_id_,
637 &event)); 638 &event));
638 return true; 639 return true;
639 } 640 }
640 641
641 } // namespace content 642 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698