Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2887963002: Revert of [Telemetry][CodeHealth] Make unittests with fake platforms use fakes.FakePlatform (Closed)

Created:
3 years, 7 months ago by rnephew (Reviews Here)
Modified:
3 years, 7 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Telemetry][CodeHealth] Make unittests with fake platforms use fakes.FakePlatform (patchset #3 id:60001 of https://codereview.chromium.org/2889583003/ ) Reason for revert: Causes circular dependency Original issue's description: > [Telemetry][CodeHealth] Make unittests with fake platforms use fakes.FakePlatform > > Review-Url: https://codereview.chromium.org/2889583003 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/8b1e70dd66320bb84b8d7efe30016ea0e5023097 TBR=charliea@chromium.org,nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2887963002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/5aee601d9795fd83b28c0cfe1c23b358b1b55dea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -40 lines) Patch
M telemetry/telemetry/internal/browser/tab_unittest.py View 3 chunks +31 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py View 4 chunks +28 lines, -8 lines 0 comments Download
M telemetry/telemetry/internal/story_runner_unittest.py View 3 chunks +16 lines, -2 lines 0 comments Download
M telemetry/telemetry/testing/fakes/__init__.py View 4 chunks +1 line, -28 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rnephew (Reviews Here)
Created Revert of [Telemetry][CodeHealth] Make unittests with fake platforms use fakes.FakePlatform
3 years, 7 months ago (2017-05-16 20:33:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887963002/1
3 years, 7 months ago (2017-05-16 20:33:38 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 20:33:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698