Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2887933002: Remove usage of SequencedWorkerPool::GetNamedSequenceToken from ChromeDownloadManagerDelegate. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, tfarina, yamaguchi+watch_chromium.org, oka+watch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of SequencedWorkerPool::GetNamedSequenceToken from ChromeDownloadManagerDelegate. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 TBR=hirono@chromium.org, kinuko@chromium.org, Review-Url: https://codereview.chromium.org/2887933002 Cr-Commit-Position: refs/heads/master@{#473894} Committed: https://chromium.googlesource.com/chromium/src/+/53943c16ba00d6b9771a5a3e14852b516207139a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -27 lines) Patch
M chrome/browser/chromeos/drive/download_handler.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/download_handler.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.h View 3 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate.cc View 4 chunks +17 lines, -15 lines 0 comments Download
M content/public/browser/download_manager_delegate.h View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
fdoray
Please take a look. In particular, please make sure that appropriate traits are used to ...
3 years, 7 months ago (2017-05-17 14:43:31 UTC) #6
fdoray
On 2017/05/17 14:43:31, fdoray wrote: > Please take a look. > > In particular, please ...
3 years, 7 months ago (2017-05-19 20:07:45 UTC) #7
David Trainor- moved to gerrit
lgtm
3 years, 7 months ago (2017-05-19 20:59:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887933002/1
3 years, 7 months ago (2017-05-21 15:11:13 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/443347)
3 years, 7 months ago (2017-05-21 15:17:44 UTC) #12
fdoray
TBR hirono@chromium.org for changes to chrome/browser/chromeos/ TBR kinuko@chromium.org for changes to content/
3 years, 7 months ago (2017-05-23 13:59:21 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887933002/1
3 years, 7 months ago (2017-05-23 13:59:41 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/53943c16ba00d6b9771a5a3e14852b516207139a
3 years, 7 months ago (2017-05-23 15:00:32 UTC) #22
kinuko
lgtm
3 years, 7 months ago (2017-05-24 00:16:49 UTC) #23
hirono
3 years, 7 months ago (2017-05-24 01:01:50 UTC) #24
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698