third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js - Issue 2887923002: DevTools: fix network grid scroll to bottom, render group node frame icon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js

Issue 2887923002: DevTools: fix network grid scroll to bottom, render group node frame icon. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js ('K') | « third_party/WebKit/Source/devtools/front_end/network/networkLogView.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js

diff --git a/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js b/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js

index 814e27b7ba43d4699d47febbbc0c3763c040f78a..ba83324018247bda9b38c988e58b3911f43c9b3b 100644

--- a/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js

+++ b/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js

@@ -75,10 +75,11 @@ ProductRegistry.BadgePool = class {

* @param {!Element} badgeElement

async _renderBadge(badgeElement) {

+ var registry = await ProductRegistry.instance();

if (!this._badgeElements.has(badgeElement))

return;

- var registry = await ProductRegistry.instance();

var parsedUrl = await this._badgeElements.get(badgeElement)();

var entryName = registry.nameForUrl(parsedUrl);