DevTools: fix network grid scroll to bottom, render group node frame icon.

third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  * @extends {DataGrid.DataGrid<!NODE_TYPE>}
  * @template NODE_TYPE
  */
 DataGrid.ViewportDataGrid = class extends DataGrid.DataGrid {
   /**
    * @param {!Array.<!DataGrid.DataGrid.ColumnDescriptor>} columnsArray
    * @param {function(!NODE_TYPE, string, string, string)=} editCallback
    * @param {function(!NODE_TYPE)=} deleteCallback
    * @param {function()=} refreshCallback
    */
   constructor(columnsArray, editCallback, deleteCallback, refreshCallback) {
     super(columnsArray, editCallback, deleteCallback, refreshCallback);
 
     this._onScrollBound = this._onScroll.bind(this);
     this._scrollContainer.addEventListener('scroll', this._onScrollBound, true);
 
     /** @type {!Array.<!DataGrid.ViewportDataGridNode>} */
     this._visibleNodes = [];
     this._inline = false;
 
     this._stickToBottom = false;
     this._updateIsFromUser = false;
-    this._atBottom = true;
     this._lastScrollTop = 0;
     this._firstVisibleIsStriped = false;
 
     this.setRootNode(new DataGrid.ViewportDataGridNode());
   }
 
   /**
    * @param {!Element} scrollContainer
    */
   setScrollContainer(scrollContainer) {
     this._scrollContainer.removeEventListener('scroll', this._onScrollBound, true);
     this._scrollContainer = scrollContainer;
     this._scrollContainer.addEventListener('scroll', this._onScrollBound, true);
   }
 
   /**
    * @override
    */
   onResize() {
-    if (this._stickToBottom && this._atBottom)
+    if (this._stickToBottom)
       this._scrollContainer.scrollTop = this._scrollContainer.scrollHeight - this._scrollContainer.clientHeight;
     this.scheduleUpdate();
     super.onResize();
   }
 
   /**
    * @param {boolean} stick
    */
   setStickToBottom(stick) {
     this._stickToBottom = stick;
   }
 
   /**
    * @param {?Event} event
    */
   _onScroll(event) {
-    this._atBottom = this._scrollContainer.isScrolledToBottom();
+    this._stickToBottom = this._scrollContainer.isScrolledToBottom();
     if (this._lastScrollTop !== this._scrollContainer.scrollTop)
       this.scheduleUpdate(true);
   }
 
   /**
    * @protected
    */
   scheduleUpdateStructure() {
     this.scheduleUpdate();
   }
 
   /**
    * @param {boolean=} isFromUser
    */
   scheduleUpdate(isFromUser) {
+    if (this._stickToBottom && isFromUser)
+      this._stickToBottom = this._scrollContainer.isScrolledToBottom();
     this._updateIsFromUser = this._updateIsFromUser || isFromUser;
     if (this._updateAnimationFrameId)
       return;
     this._updateAnimationFrameId = this.element.window().requestAnimationFrame(this._update.bind(this));
   }
 
   // TODO(allada) This should be fixed to never be needed. It is needed right now for network because removing
   // elements happens followed by a scheduleRefresh() which causes white space to be visible, but the waterfall
   // updates instantly.
   updateInstantly() {
@@ skipping 59 matching lines @@
   _update() {
     if (this._updateAnimationFrameId) {
       this.element.window().cancelAnimationFrame(this._updateAnimationFrameId);
       delete this._updateAnimationFrameId;
     }
 
     var clientHeight = this._scrollContainer.clientHeight;
     var scrollTop = this._scrollContainer.scrollTop;
     var currentScrollTop = scrollTop;
     var maxScrollTop = Math.max(0, this._contentHeight() - clientHeight);
-    if (!this._updateIsFromUser && this._stickToBottom && this._atBottom)
+    if (!this._updateIsFromUser && this._stickToBottom)
       scrollTop = maxScrollTop;
     this._updateIsFromUser = false;
     scrollTop = Math.min(maxScrollTop, scrollTop);
-    this._atBottom = scrollTop === maxScrollTop;
 
     var viewportState = this._calculateVisibleNodes(clientHeight, scrollTop);
     var visibleNodes = viewportState.visibleNodes;
     var visibleNodesSet = new Set(visibleNodes);
 
     for (var i = 0; i < this._visibleNodes.length; ++i) {
       var oldNode = this._visibleNodes[i];
       if (!visibleNodesSet.has(oldNode) && oldNode.attached()) {
         var element = oldNode.existingElement();
         element.remove();
@@ skipping 46 matching lines @@
     if (index === -1)
       return;
     var fromY = 0;
     for (var i = 0; i < index; ++i)
       fromY += nodes[i].nodeSelfHeight();
     var toY = fromY + node.nodeSelfHeight();
 
     var scrollTop = this._scrollContainer.scrollTop;
     if (scrollTop > fromY) {
       scrollTop = fromY;
-      this._atBottom = false;
+      this._stickToBottom = false;
     } else if (scrollTop + this._scrollContainer.offsetHeight < toY) {
       scrollTop = toY - this._scrollContainer.offsetHeight;
     }
     this._scrollContainer.scrollTop = scrollTop;
   }
 };
 
 DataGrid.ViewportDataGrid.Events = {
   ViewportCalculated: Symbol('ViewportCalculated')
 };
@@ skipping 171 matching lines @@
       this.existingElement().classList.remove('expanded');
     this.dataGrid.scheduleUpdateStructure();
   }
 
   /**
    * @override
    */
   expand() {
     if (this._expanded)
       return;
+    this.dataGrid._stickToBottom = false;
     this.clearFlatNodes();
     super.expand();
     this.dataGrid.scheduleUpdateStructure();
   }
 
   /**
    * @protected
    * @return {boolean}
    */
   attached() {
@@ skipping 21 matching lines @@
 
   /**
    * @override
    * @param {number} index
    */
   recalculateSiblings(index) {
     this.clearFlatNodes();
     super.recalculateSiblings(index);
   }
 };