Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2887913005: Image Capture: reject applyConstraints() if there isn't any recognized member (Closed)

Created:
3 years, 7 months ago by mcasas
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Image Capture: reject applyConstraints() if there isn't any recognized member This CL corrects the code so that theTrack.applyConstraints({ advanced: [{blergh : 100}]}); will be rejected due to unknown dictionary members, also adding a Layout Tests entry. To reject, the logic in HasNonImageCaptureConstraints() is inverted, checking for the presence of image constraints (instead of checking for the absence of non-image constraints, which lets an empty dictionary through) -- Note that WebIdl will silently drop unsupported dictionary members. Bug: 723779 Change-Id: I3c911ea4d319deab828c135a9f88a3d5af0b06bf Reviewed-on: https://chromium-review.googlesource.com/508171 Commit-Queue: Miguel Casas <mcasas@chromium.org>; Reviewed-by: Reilly Grant <reillyg@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#472699} Review-Url: https://codereview.chromium.org/2887913005 . Cr-Commit-Position: refs/branch-heads/3071@{#621} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/372a89d7cf9bc06c0c00fd1394e6a727ef5619b4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints-reject.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp View 1 chunk +7 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mcasas
3 years, 7 months ago (2017-05-18 20:35:11 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
372a89d7cf9bc06c0c00fd1394e6a727ef5619b4.

Powered by Google App Engine
This is Rietveld 408576698