Chromium Code Reviews
DescriptionImage Capture: reject applyConstraints() if there isn't any recognized member
This CL corrects the code so that
theTrack.applyConstraints({ advanced: [{blergh : 100}]});
will be rejected due to unknown dictionary members, also adding
a Layout Tests entry.
To reject, the logic in HasNonImageCaptureConstraints() is
inverted, checking for the presence of image constraints (instead
of checking for the absence of non-image constraints, which lets
an empty dictionary through) -- Note that WebIdl will silently
drop unsupported dictionary members.
Bug: 723779
Change-Id: I3c911ea4d319deab828c135a9f88a3d5af0b06bf
Reviewed-on: https://chromium-review.googlesource.com/508171
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#472699}
Review-Url: https://codereview.chromium.org/2887913005 .
Cr-Commit-Position: refs/branch-heads/3071@{#621}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/372a89d7cf9bc06c0c00fd1394e6a727ef5619b4
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||