Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2887883002: Replace ASSERT with DCHECK in Nullable (Closed)

Created:
3 years, 7 months ago by pilgrim_google
Modified:
3 years, 7 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, jsbell
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT with DCHECK in Nullable This CL is separate from the others because I want to have a discussion about possible performance regressions before committing. BUG=596760 Review-Url: https://codereview.chromium.org/2887883002 Cr-Commit-Position: refs/heads/master@{#472251} Committed: https://chromium.googlesource.com/chromium/src/+/2679a47b0241a1012b2b0710663993fd6d10ee29

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/Nullable.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
pilgrim_google
3 years, 7 months ago (2017-05-16 18:18:53 UTC) #3
haraken
LGTM
3 years, 7 months ago (2017-05-16 20:15:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887883002/1
3 years, 7 months ago (2017-05-16 23:20:58 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 23:41:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2679a47b0241a1012b2b07106639...

Powered by Google App Engine
This is Rietveld 408576698