Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: src/ic/stub-cache.cc

Issue 2887783002: [gn] Allow building a snapshot with unwinding information. (Closed)
Patch Set: Fix assertion in stub-cache.cc Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | src/setup-isolate-deserialize.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/stub-cache.cc
diff --git a/src/ic/stub-cache.cc b/src/ic/stub-cache.cc
index 6396c57061d1e4cfa0d5e2ac86d36884224953f6..d58eec9cd7f4806e21c97c301168febf63d90663 100644
--- a/src/ic/stub-cache.cc
+++ b/src/ic/stub-cache.cc
@@ -41,12 +41,10 @@ bool CommonStubCacheChecks(StubCache* stub_cache, Name* name, Map* map,
if (handler) {
DCHECK(IC::IsHandler(handler));
if (handler->IsCode()) {
- Code* code = Code::cast(handler);
- Code::Flags expected_flags =
- Code::ComputeHandlerFlags(stub_cache->ic_kind());
- Code::Flags flags = code->flags();
- DCHECK_EQ(expected_flags, flags);
- DCHECK_EQ(Code::HANDLER, Code::ExtractKindFromFlags(code->flags()));
+ Code::Flags code_flags = Code::cast(handler)->flags();
+ Code::Kind ic_code_kind = stub_cache->ic_kind();
+ DCHECK_EQ(ic_code_kind, Code::ExtractExtraICStateFromFlags(code_flags));
+ DCHECK_EQ(Code::HANDLER, Code::ExtractKindFromFlags(code_flags));
}
}
return true;
« no previous file with comments | « BUILD.gn ('k') | src/setup-isolate-deserialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698