Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: src/setup-isolate-deserialize.cc

Issue 2887783002: [gn] Allow building a snapshot with unwinding information. (Closed)
Patch Set: Fix assertion in stub-cache.cc Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/stub-cache.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/setup-isolate-deserialize.cc
diff --git a/src/setup-isolate-deserialize.cc b/src/setup-isolate-deserialize.cc
index a01bb5a3f8b1a9e33928e6701cd7aa75fab8f6f9..eec5f60a33f0496a755fc4dd37113f5149a9d6d2 100644
--- a/src/setup-isolate-deserialize.cc
+++ b/src/setup-isolate-deserialize.cc
@@ -20,6 +20,14 @@ void SetupIsolateDelegate::SetupBuiltins(Isolate* isolate,
void SetupIsolateDelegate::SetupInterpreter(
interpreter::Interpreter* interpreter, bool create_heap_objects) {
+#if defined(V8_USE_SNAPSHOT) && !defined(V8_USE_SNAPSHOT_WITH_UNWINDING_INFO)
+ if (FLAG_perf_prof_unwinding_info) {
+ OFStream os(stdout);
+ os << "Warning: The --perf-prof-unwinding-info flag can be passed at "
+ "mksnapshot time to get better results."
+ << std::endl;
+ }
+#endif
DCHECK(interpreter->IsDispatchTableInitialized());
}
« no previous file with comments | « src/ic/stub-cache.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698