Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1443)

Issue 288773002: Pepper: Simplify manifest download logic. (Closed)

Created:
6 years, 7 months ago by teravest
Modified:
6 years, 7 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org
Visibility:
Public.

Description

Pepper: Simplify manifest download logic. This cleans up some of the trusted plugin logic for requesting a NaCl manifest and removes some interfaces in PPB_NaCl_Private, providing better encapsulation. This code is easier to follow after this change, as well, since more of the logic is unified in ppb_nacl_private_impl.cc. This is part of a larger effort to remove the trusted plugin. BUG=239656 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270887

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -111 lines) Patch
M components/nacl/renderer/manifest_downloader.h View 1 chunk +6 lines, -0 lines 0 comments Download
M components/nacl/renderer/manifest_downloader.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M components/nacl/renderer/nexe_load_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/nexe_load_manager.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 3 chunks +48 lines, -21 lines 0 comments Download
M ppapi/api/private/ppb_nacl_private.idl View 2 chunks +4 lines, -13 lines 0 comments Download
M ppapi/c/private/ppb_nacl_private.h View 3 chunks +5 lines, -12 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 2 chunks +6 lines, -37 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 4 chunks +3 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
teravest
6 years, 7 months ago (2014-05-14 19:48:31 UTC) #1
dmichael (off chromium)
lgtm
6 years, 7 months ago (2014-05-15 18:01:21 UTC) #2
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 7 months ago (2014-05-15 18:03:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/288773002/1
6 years, 7 months ago (2014-05-15 18:05:37 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 01:22:23 UTC) #5
Message was sent while issue was closed.
Change committed as 270887

Powered by Google App Engine
This is Rietveld 408576698