Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Unified Diff: components/nacl/renderer/nexe_load_manager.cc

Issue 288773002: Pepper: Simplify manifest download logic. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/nacl/renderer/nexe_load_manager.h ('k') | components/nacl/renderer/ppb_nacl_private_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/renderer/nexe_load_manager.cc
diff --git a/components/nacl/renderer/nexe_load_manager.cc b/components/nacl/renderer/nexe_load_manager.cc
index 658f0cf9d680aaf0151cda4191cb6a3ac433704d..1d34a7dd803e539692bbb5ec699523b128a8bf60 100644
--- a/components/nacl/renderer/nexe_load_manager.cc
+++ b/components/nacl/renderer/nexe_load_manager.cc
@@ -337,16 +337,14 @@ void NexeLoadManager::ReportStartupOverhead() const {
"NaCl.Perf.StartupTime.NaClOverhead", overhead, nexe_size_);
}
-bool NexeLoadManager::RequestNaClManifest(const std::string& url,
- bool* is_data_uri) {
+bool NexeLoadManager::RequestNaClManifest(const std::string& url) {
if (plugin_base_url_.is_valid()) {
const GURL& resolved_url = plugin_base_url_.Resolve(url);
if (resolved_url.is_valid()) {
manifest_base_url_ = resolved_url;
is_installed_ = manifest_base_url_.SchemeIs("chrome-extension");
- *is_data_uri = manifest_base_url_.SchemeIs("data");
- HistogramEnumerateManifestIsDataURI(*is_data_uri);
-
+ HistogramEnumerateManifestIsDataURI(
+ manifest_base_url_.SchemeIs("data"));
set_nacl_ready_state(PP_NACL_READY_STATE_OPENED);
DispatchProgressEvent(pp_instance_,
ProgressEvent(PP_NACL_EVENT_LOADSTART));
« no previous file with comments | « components/nacl/renderer/nexe_load_manager.h ('k') | components/nacl/renderer/ppb_nacl_private_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698