Break dependency on ChromeClientImpl for WebPluginContainerImpl.

Break dependency on ChromeClientImpl for WebPluginContainerImpl.

Move methods that were not virtual in ChromeClientImpl to ChromeClient and make
them pure virtual, override in ChromeClientImpl.

BUG=708879
Review-Url: https://codereview.chromium.org/2887633002
Cr-Commit-Position: refs/heads/master@{#472730}
Committed: https://chromium.googlesource.com/chromium/src/+/51c37035a1100e4c6e7257e4289870f7f2ac27db

[slangley, 2017-05-16 07:24:57]

Description was changed from

==========
Break dependency on ChromeClientImpl for WebPluginContainerImpl.

Move methods that were not virtual in ChromeClientImpl to ChromeClient and make
them pure virtual, override in ChromeClientImpl.

BUG=
==========

to

==========
Break dependency on ChromeClientImpl for WebPluginContainerImpl.

Move methods that were not virtual in ChromeClientImpl to ChromeClient and make
them pure virtual, override in ChromeClientImpl.

BUG=708879
==========

[slangley, 2017-05-16 07:24:57]

slangley@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2017-05-16 07:43:38]

lgtm

[slangley, 2017-05-16 22:45:02]

The CQ bit was checked by slangley@chromium.org

[commit-bot: I haz the power, 2017-05-16 22:46:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 01:05:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 01:05:25]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[slangley, 2017-05-17 04:58:33]

The CQ bit was checked by slangley@chromium.org

[commit-bot: I haz the power, 2017-05-17 04:59:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 06:27:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 06:27:49]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[slangley, 2017-05-17 11:36:22]

The CQ bit was checked by slangley@chromium.org

[commit-bot: I haz the power, 2017-05-17 11:36:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 13:02:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 13:02:54]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[slangley, 2017-05-17 20:54:21]

The CQ bit was checked by slangley@chromium.org

[commit-bot: I haz the power, 2017-05-17 20:55:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 00:01:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 00:01:35]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[slangley, 2017-05-18 00:36:37]

The CQ bit was checked by slangley@chromium.org

[slangley, 2017-05-18 00:36:37]

The CQ bit was checked by slangley@chromium.org

[commit-bot: I haz the power, 2017-05-18 00:38:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 03:25:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 03:25:39]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[slangley, 2017-05-18 03:49:55]

The CQ bit was checked by slangley@chromium.org

[commit-bot: I haz the power, 2017-05-18 03:51:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 07:55:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495079395751940, "parent_rev":
"1870aebe1a769e4220a3ba1025bed28d19300c71", "commit_rev":
"51c37035a1100e4c6e7257e4289870f7f2ac27db"}

[commit-bot: I haz the power, 2017-05-18 07:55:46]

Description was changed from

==========
Break dependency on ChromeClientImpl for WebPluginContainerImpl.

Move methods that were not virtual in ChromeClientImpl to ChromeClient and make
them pure virtual, override in ChromeClientImpl.

BUG=708879
==========

to

==========
Break dependency on ChromeClientImpl for WebPluginContainerImpl.

Move methods that were not virtual in ChromeClientImpl to ChromeClient and make
them pure virtual, override in ChromeClientImpl.

BUG=708879

Review-Url: https://codereview.chromium.org/2887633002
Cr-Commit-Position: refs/heads/master@{#472730}
Committed:
https://chromium.googlesource.com/chromium/src/+/51c37035a1100e4c6e7257e42898...
==========

[commit-bot: I haz the power, 2017-05-18 07:55:47]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/51c37035a1100e4c6e7257e42898...