Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2887613002: Revert of Rename AXObject to AXObjectImpl in modules/ and web/ (patchset #9 id:160001 of https://co… (Closed)

Created:
3 years, 7 months ago by sashab
Modified:
3 years, 7 months ago
CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, Rik, chromium-reviews, dglazkov+blink, dmazzoni, dmazzoni+watch_chromium.org, dshwang, dougt+watch_chromium.org, dtseng+watch_chromium.org, eae+blinkwatch, haraken, je_julie, Justin Novosad, kinuko+watch, nektar+watch_chromium.org, nektarios, rwlbuis, sof, yuzo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Rename AXObject to AXObjectImpl in modules/ and web/ (patchset #9 id:160001 of https://codereview.chromium.org/2858493002/ ) Reason for revert: Landed wrong patchset. Original issue's description: > Rename AXObject to AXObjectImpl in modules/ and web/ > > Rename AXObject to AXObjectImpl in modules/ and web/, and introduce an > empty abstract parent class in core/. This is pre-work to remove usages > of AXObjectImpl from web/, which will use AXObject instead. > > This patch does not rename the usages in core/ since these should use > the new abstract object. > > BUG=715382 > > Review-Url: https://codereview.chromium.org/2858493002 > Cr-Commit-Position: refs/heads/master@{#471663} > Committed: https://chromium.googlesource.com/chromium/src/+/234813ae8d52f622a1664e11365642751e8f26ba TBR=aboxhall@chromium.org,dmazzoni@chromium.org,haraken@chromium.org,mkwst@chromium.org,slangley@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=715382 Review-Url: https://codereview.chromium.org/2887613002 Cr-Commit-Position: refs/heads/master@{#472281} Committed: https://chromium.googlesource.com/chromium/src/+/b498325ab6ea7c253b73d65eaf15de7c9bf073e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+795 lines, -3865 lines) Patch
M docs/accessibility/overview.md View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/corresponding-control-deleted-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/display-none-change.html View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/not-ignore-landmark-roles-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/AXObjectCache.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/ColorChooser.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/ColorInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/ColorInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/DateTimeChooser.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputTypeView.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputTypeView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/PickerIndicatorElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/PickerIndicatorElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/PagePopup.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXARIAGrid.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp View 4 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXARIAGridRow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXImageMapLink.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp View 8 chunks +11 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h View 6 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 50 chunks +64 lines, -69 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXListBox.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXListBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMediaControls.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp View 4 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMockObject.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXMockObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.h View 6 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 54 chunks +81 lines, -85 lines 0 comments Download
A + third_party/WebKit/Source/modules/accessibility/AXObject.h View 25 chunks +53 lines, -58 lines 0 comments Download
A + third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 73 chunks +150 lines, -163 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h View 10 chunks +31 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp View 52 chunks +84 lines, -89 lines 0 comments Download
D third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h View 1 chunk +0 lines, -1143 lines 0 comments Download
D third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp View 1 chunk +0 lines, -1884 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectTest.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXRadioInput.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXSVGRoot.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXSVGRoot.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXSlider.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXSlider.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXSpinButton.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTable.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTable.cpp View 7 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableCell.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableColumn.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableColumn.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableRow.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h View 3 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 24 chunks +42 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp View 4 chunks +7 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/testing/InternalsAccessibility.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DAPITest.cpp View 5 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DUsageTrackingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/AssertMatchingEnums.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ColorChooserPopupUIController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ColorChooserPopupUIController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ColorChooserUIController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ColorChooserUIController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/DateTimeChooserImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/DateTimeChooserImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ExternalDateTimeChooser.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/TextFinder.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 23 chunks +29 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/web/WebDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebNode.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebAXObject.h View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887613002/1
3 years, 7 months ago (2017-05-16 03:41:06 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/445470)
3 years, 7 months ago (2017-05-16 09:35:24 UTC) #6
dmazzoni
Consider using NOTRY=true for a revert, especially soon after landing
3 years, 7 months ago (2017-05-16 16:00:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887613002/1
3 years, 7 months ago (2017-05-17 01:16:36 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 01:19:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b498325ab6ea7c253b73d65eaf15...

Powered by Google App Engine
This is Rietveld 408576698