DevTools: Attempt to get badges from StackTrace in console

third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index 1359d4fcd127582c0076cd5e99708ba1551961f9..ee36d6472f34f467a2e4a420617092c9999c79cf 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -301,6 +301,25 @@ Console.ConsoleViewMessage = class {
    * @return {?Element}
    */
   _buildMessageBadge() {
+    var badgeElement = this._badgeElement();
+    if (!badgeElement)
+      return null;
+    badgeElement.classList.add('console-message-badge');
+    return badgeElement;
+  }
+
+  /**
+   * @return {?Element}
+   */
+  _badgeElement() {
+    if (this._message._url)
+      return this._badgePool.badgeForURL(new Common.ParsedURL(this._message._url));
+    if (this._message.stackTrace) {
+      for (var callFrame of this._message.stackTrace.callFrames) {

[pfeldman, 2017/05/16 20:30:06]

What about async chain frames? You could go all the way blaming...

[einbinder, 2017/05/16 20:41:34]

Done.

+        if (callFrame.url)
+          return this._badgePool.badgeForURL(new Common.ParsedURL(callFrame.url));

[pfeldman, 2017/05/16 20:30:06]

Do you want the first mapped url or any first url badge?

[einbinder, 2017/05/16 20:41:34]

I think I want the first URL for now. I want to try to stay close to what the
user sees for the linked url, unless that url is VM###.

+      }
+    }
     if (!this._message.executionContextId)
       return null;
     var runtimeModel = this._message.runtimeModel();
@@ -315,9 +334,7 @@ Console.ConsoleViewMessage = class {
     var frame = resourceTreeModel.frameForId(executionContext.frameId);
     if (!frame || !frame.parentFrame)
       return null;
-    var badgeElement = this._badgePool.badgeForFrame(frame);
-    badgeElement.classList.add('console-message-badge');
-    return badgeElement;
+    return this._badgePool.badgeForFrame(frame);
   }
 
   /**