DevTools: Attempt to get badges from StackTrace in console

third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 283 matching lines @@
       anchorWrapperElement.createTextChild(' ');
       return anchorWrapperElement;
     }
     return null;
   }
 
   /**
    * @return {?Element}
    */
   _buildMessageBadge() {
+    var badgeElement = this._badgeElement();
+    if (!badgeElement)
+      return null;
+    badgeElement.classList.add('console-message-badge');
+    return badgeElement;
+  }
+
+  /**
+   * @return {?Element}
+   */
+  _badgeElement() {
+    if (this._message._url)
+      return this._badgePool.badgeForURL(new Common.ParsedURL(this._message._url));
+    if (this._message.stackTrace) {
+      for (var callFrame of this._message.stackTrace.callFrames) {

[pfeldman, 2017/05/16 20:30:06]

What about async chain frames? You could go all the way blaming...

[einbinder, 2017/05/16 20:41:34]

Done.

+        if (callFrame.url)
+          return this._badgePool.badgeForURL(new Common.ParsedURL(callFrame.url));

[pfeldman, 2017/05/16 20:30:06]

Do you want the first mapped url or any first url badge?

[einbinder, 2017/05/16 20:41:34]

I think I want the first URL for now. I want to try to stay close to what the
user sees for the linked url, unless that url is VM###.

+      }
+    }
     if (!this._message.executionContextId)
       return null;
     var runtimeModel = this._message.runtimeModel();
     if (!runtimeModel)
       return null;
     var executionContext = runtimeModel.executionContext(this._message.executionContextId);
     if (!executionContext || !executionContext.frameId)
       return null;
     var resourceTreeModel = executionContext.target().model(SDK.ResourceTreeModel);
     if (!resourceTreeModel)
       return null;
     var frame = resourceTreeModel.frameForId(executionContext.frameId);
     if (!frame || !frame.parentFrame)
       return null;
-    var badgeElement = this._badgePool.badgeForFrame(frame);
-    badgeElement.classList.add('console-message-badge');
-    return badgeElement;
+    return this._badgePool.badgeForFrame(frame);
   }
 
   /**
    * @return {!Element}
    */
   _buildMessageWithStackTrace() {
     var toggleElement = createElementWithClass('div', 'console-message-stack-trace-toggle');
     var contentElement = toggleElement.createChild('div', 'console-message-stack-trace-wrapper');
 
     var messageElement = this._buildMessage();
@@ skipping 917 matching lines @@
   toMessageElement() {
     if (!this._element) {
       super.toMessageElement();
       this._expandGroupIcon = UI.Icon.create('', 'expand-group-icon');
       this._contentElement.insertBefore(this._expandGroupIcon, this._contentElement.firstChild);
       this.setCollapsed(this._collapsed);
     }
     return this._element;
   }
 };