Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2887593002:
Disable style sharing outside tests. (Closed)
DescriptionDisable style sharing outside tests.
This disables style sharing for most users in Canary, but leaves the code and
leaves it enabled in the layout tests. Once this bakes for a little while we
can then remove the code and update the tests.
Per the style-dev@ discussion and design doc:
https://groups.google.com/a/chromium.org/forum/#!topic/style-dev/8BV0QYubjos
Pateched in from esprehn's patch: http://crrev.com/2858423002
BUG=721517
Review-Url: https://codereview.chromium.org/2887593002
Cr-Commit-Position: refs/heads/master@{#475317}
Committed: https://chromium.googlesource.com/chromium/src/+/cc275c99719dca651110ad31085c6401de79056a
Patch Set 1 #
Messages
Total messages: 29 (16 generated)
The CQ bit was checked by nainar@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
nainar@chromium.org changed reviewers: + dstockwell@chromium.org
dstockwell@, PTAL? Thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by nainar@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rune@opera.com changed reviewers: + rune@opera.com
lgtm Was the telemetry fail in the original CL unrelated to the patch?
On 2017/05/16 at 09:11:11, rune wrote: > lgtm > > Was the telemetry fail in the original CL unrelated to the patch? Thank you for the LGTM. Will look to land this after the branch freeze. The test suite in question was deleted in this CL: https://codereview.chromium.org/2885563002. The bug linked through in the CL has more data.
lgtm
The CQ bit was checked by nainar@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
nainar@chromium.org changed reviewers: + haraken@chromium.org
haraken, For OWNERS on platform/. PTAL? Thanks!
This changes a web-exposed behavior, so you'll need to get an approval from an API OWNER.
On 2017/05/29 at 07:26:26, haraken wrote: > This changes a web-exposed behavior, so you'll need to get an approval from an API OWNER. Did you have a particular concern? There shouldn't be anything web-exposed here, it's an implementation detail, not a web-facing API.
On 2017/05/29 08:04:35, dstockwell wrote: > On 2017/05/29 at 07:26:26, haraken wrote: > > This changes a web-exposed behavior, so you'll need to get an approval from an > API OWNER. > > Did you have a particular concern? There shouldn't be anything web-exposed here, > it's an implementation detail, not a web-facing API. Ah, makes sense. LGTM.
On 2017/05/29 at 08:07:07, haraken wrote: > On 2017/05/29 08:04:35, dstockwell wrote: > > On 2017/05/29 at 07:26:26, haraken wrote: > > > This changes a web-exposed behavior, so you'll need to get an approval from an > > API OWNER. > > > > Did you have a particular concern? There shouldn't be anything web-exposed here, > > it's an implementation detail, not a web-facing API. > > Ah, makes sense. LGTM. Thank you for taking a look haraken!
The CQ bit was checked by nainar@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1496048617478930, "parent_rev":
"2da4c09d784da8f90c2e41418e92533abb9f5612", "commit_rev":
"cc275c99719dca651110ad31085c6401de79056a"}
Message was sent while issue was closed.
Description was changed from ========== Disable style sharing outside tests. This disables style sharing for most users in Canary, but leaves the code and leaves it enabled in the layout tests. Once this bakes for a little while we can then remove the code and update the tests. Per the style-dev@ discussion and design doc: https://groups.google.com/a/chromium.org/forum/#!topic/style-dev/8BV0QYubjos Pateched in from esprehn's patch: http://crrev.com/2858423002 BUG=721517 ========== to ========== Disable style sharing outside tests. This disables style sharing for most users in Canary, but leaves the code and leaves it enabled in the layout tests. Once this bakes for a little while we can then remove the code and update the tests. Per the style-dev@ discussion and design doc: https://groups.google.com/a/chromium.org/forum/#!topic/style-dev/8BV0QYubjos Pateched in from esprehn's patch: http://crrev.com/2858423002 BUG=721517 Review-Url: https://codereview.chromium.org/2887593002 Cr-Commit-Position: refs/heads/master@{#475317} Committed: https://chromium.googlesource.com/chromium/src/+/cc275c99719dca651110ad31085c... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/cc275c99719dca651110ad31085c... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
