Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2887583002: VR: Apply color to URL bar security icons. (Closed)

Created:
3 years, 7 months ago by cjgrant
Modified:
3 years, 7 months ago
Reviewers:
mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Apply color to URL bar security icons. BUG=715665 Review-Url: https://codereview.chromium.org/2887583002 Cr-Commit-Position: refs/heads/master@{#471996} Committed: https://chromium.googlesource.com/chromium/src/+/dd78b5d7e2b3613a2e8b205aa7d1143bfc9ce2de

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M chrome/browser/android/vr_shell/textures/url_bar_texture.cc View 3 chunks +25 lines, -5 lines 1 comment Download

Depends on Patchset:

Issue 2877133002 Patch 100001

Messages

Total messages: 9 (4 generated)
cjgrant
3 years, 7 months ago (2017-05-15 21:52:18 UTC) #2
cjgrant
https://codereview.chromium.org/2887583002/diff/1/chrome/browser/android/vr_shell/textures/url_bar_texture.cc File chrome/browser/android/vr_shell/textures/url_bar_texture.cc (right): https://codereview.chromium.org/2887583002/diff/1/chrome/browser/android/vr_shell/textures/url_bar_texture.cc#newcode61 chrome/browser/android/vr_shell/textures/url_bar_texture.cc:61: SkColor getSecurityIconColor(int level) { This seems cleaner than the ...
3 years, 7 months ago (2017-05-15 21:53:17 UTC) #3
mthiesse
lgtm
3 years, 7 months ago (2017-05-15 22:39:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887583002/1
3 years, 7 months ago (2017-05-16 01:01:52 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 03:00:39 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dd78b5d7e2b3613a2e8b205aa7d1...

Powered by Google App Engine
This is Rietveld 408576698