Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2887573002: Add deprecation messages. (Closed)

Created:
3 years, 7 months ago by Jamie
Modified:
3 years, 7 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add deprecation messages. Review-Url: https://codereview.chromium.org/2887573002 Cr-Commit-Position: refs/heads/master@{#472851} Committed: https://chromium.googlesource.com/chromium/src/+/53ea5fe3473c86b5243ba83f9d0fb20761ac1fe3

Patch Set 1 #

Total comments: 12

Patch Set 2 : Reviewer feedback. #

Patch Set 3 : Restore clock in tearDown. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -59 lines) Patch
M remoting/resources/remoting_strings.grd View 3 chunks +12 lines, -6 lines 0 comments Download
M remoting/webapp/crd/html/butter_bar.css View 1 1 chunk +5 lines, -0 lines 0 comments Download
M remoting/webapp/crd/js/butter_bar.js View 1 4 chunks +94 lines, -51 lines 0 comments Download
A remoting/webapp/crd/js/butter_bar_unittest.js View 1 2 1 chunk +167 lines, -0 lines 0 comments Download
M remoting/webapp/crd/js/crd_main.js View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/webapp/files.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 30 (15 generated)
Jamie
ptal
3 years, 7 months ago (2017-05-15 21:43:36 UTC) #2
kelvinp
https://codereview.chromium.org/2887573002/diff/1/remoting/resources/remoting_strings.grd File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/2887573002/diff/1/remoting/resources/remoting_strings.grd#newcode1215 remoting/resources/remoting_strings.grd:1215: Chrome Remote Desktop is now on the web! Check ...
3 years, 7 months ago (2017-05-15 22:36:55 UTC) #3
Do not use (sergeyu)
https://codereview.chromium.org/2887573002/diff/1/remoting/resources/remoting_strings.grd File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/2887573002/diff/1/remoting/resources/remoting_strings.grd#newcode1215 remoting/resources/remoting_strings.grd:1215: Chrome Remote Desktop is now on the web! Check ...
3 years, 7 months ago (2017-05-15 22:50:01 UTC) #5
Jamie
PTAL https://codereview.chromium.org/2887573002/diff/1/remoting/resources/remoting_strings.grd File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/2887573002/diff/1/remoting/resources/remoting_strings.grd#newcode1215 remoting/resources/remoting_strings.grd:1215: Chrome Remote Desktop is now on the web! ...
3 years, 7 months ago (2017-05-15 23:43:20 UTC) #6
kelvinp
lgtm
3 years, 7 months ago (2017-05-16 23:57:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887573002/20001
3 years, 7 months ago (2017-05-17 00:18:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/455511)
3 years, 7 months ago (2017-05-17 02:05:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887573002/20001
3 years, 7 months ago (2017-05-17 16:12:09 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/456134)
3 years, 7 months ago (2017-05-17 17:42:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887573002/40001
3 years, 7 months ago (2017-05-17 18:32:53 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/447447)
3 years, 7 months ago (2017-05-17 20:51:05 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887573002/40001
3 years, 7 months ago (2017-05-17 20:56:40 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/430076)
3 years, 7 months ago (2017-05-18 03:08:06 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887573002/40001
3 years, 7 months ago (2017-05-18 15:46:19 UTC) #27
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 17:11:41 UTC) #30
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/53ea5fe3473c86b5243ba83f9d0f...

Powered by Google App Engine
This is Rietveld 408576698