|
|
DescriptionAdd deprecation messages.
Review-Url: https://codereview.chromium.org/2887573002
Cr-Commit-Position: refs/heads/master@{#472851}
Committed: https://chromium.googlesource.com/chromium/src/+/53ea5fe3473c86b5243ba83f9d0fb20761ac1fe3
Patch Set 1 #
Total comments: 12
Patch Set 2 : Reviewer feedback. #Patch Set 3 : Restore clock in tearDown. #
Messages
Total messages: 30 (15 generated)
jamiewalch@chromium.org changed reviewers: + kelvinp@chromium.org
ptal
https://codereview.chromium.org/2887573002/diff/1/remoting/resources/remoting... File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/2887573002/diff/1/remoting/resources/remoting... remoting/resources/remoting_strings.grd:1215: Chrome Remote Desktop is now on the web! Check out our <ph name="LINK_BEGIN">$1<ex><a href=http://example.com></ex></ph>free web app<ph name="LINK_END">$2<ex></a></ex></ph>. We should probably create a Chromoting and a Chrome Remote Desktop version of the string just like the other strings. https://codereview.chromium.org/2887573002/diff/1/remoting/webapp/crd/js/butt... File remoting/webapp/crd/js/butter_bar.js (right): https://codereview.chromium.org/2887573002/diff/1/remoting/webapp/crd/js/butt... remoting/webapp/crd/js/butter_bar.js:67: 'click', this.dismiss.bind(this, false), false); dismiss does not take any parameter. https://codereview.chromium.org/2887573002/diff/1/remoting/webapp/crd/js/butt... remoting/webapp/crd/js/butter_bar.js:70: this.root_.classList.add('important'); why is important needed? https://codereview.chromium.org/2887573002/diff/1/remoting/webapp/crd/js/butt... remoting/webapp/crd/js/butter_bar.js:93: var elapsed = new Date - messageState.timestamp; s/Date/Date() for consistency https://codereview.chromium.org/2887573002/diff/1/remoting/webapp/crd/js/butt... remoting/webapp/crd/js/butter_bar.js:96: !this.messages_[this.currentMessage_].dismissable || On the first run, messageState.index is set to -1, this.currentMessage_ is also -1 This will execute !this.messages_[this.currentMessage_] which will cause index out of bound
sergeyu@google.com changed reviewers: + sergeyu@google.com
https://codereview.chromium.org/2887573002/diff/1/remoting/resources/remoting... File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/2887573002/diff/1/remoting/resources/remoting... remoting/resources/remoting_strings.grd:1215: Chrome Remote Desktop is now on the web! Check out our <ph name="LINK_BEGIN">$1<ex><a href=http://example.com></ex></ph>free web app<ph name="LINK_END">$2<ex></a></ex></ph>. nit: Not sure if an average user would know what is "web app" and how the current version is not a "web app". Maybe simplify this message to something to say it's a new and improved version without going into details? Sorry if this was already discussed before somewhere else.
PTAL https://codereview.chromium.org/2887573002/diff/1/remoting/resources/remoting... File remoting/resources/remoting_strings.grd (right): https://codereview.chromium.org/2887573002/diff/1/remoting/resources/remoting... remoting/resources/remoting_strings.grd:1215: Chrome Remote Desktop is now on the web! Check out our <ph name="LINK_BEGIN">$1<ex><a href=http://example.com></ex></ph>free web app<ph name="LINK_END">$2<ex></a></ex></ph>. On 2017/05/15 22:36:54, kelvinp wrote: > We should probably create a Chromoting and a Chrome Remote Desktop version of > the string just like the other strings. I considered that, but since the website is strictly CRD, not Chromoting, I think this is correct. https://codereview.chromium.org/2887573002/diff/1/remoting/resources/remoting... remoting/resources/remoting_strings.grd:1215: Chrome Remote Desktop is now on the web! Check out our <ph name="LINK_BEGIN">$1<ex><a href=http://example.com></ex></ph>free web app<ph name="LINK_END">$2<ex></a></ex></ph>. On 2017/05/15 22:50:01, Do not use (sergeyu) wrote: > nit: Not sure if an average user would know what is "web app" and how the > current version is not a "web app". Maybe simplify this message to something to > say it's a new and improved version without going into details? > Sorry if this was already discussed before somewhere else. I agree with you, but this is the terminology we've been asked to use. https://codereview.chromium.org/2887573002/diff/1/remoting/webapp/crd/js/butt... File remoting/webapp/crd/js/butter_bar.js (right): https://codereview.chromium.org/2887573002/diff/1/remoting/webapp/crd/js/butt... remoting/webapp/crd/js/butter_bar.js:67: 'click', this.dismiss.bind(this, false), false); On 2017/05/15 22:36:54, kelvinp wrote: > dismiss does not take any parameter. Done, and updated unit tests. https://codereview.chromium.org/2887573002/diff/1/remoting/webapp/crd/js/butt... remoting/webapp/crd/js/butter_bar.js:70: this.root_.classList.add('important'); On 2017/05/15 22:36:54, kelvinp wrote: > why is important needed? It's a class name. I've renamed it though, since it's confusing, and added a unit test. https://codereview.chromium.org/2887573002/diff/1/remoting/webapp/crd/js/butt... remoting/webapp/crd/js/butter_bar.js:93: var elapsed = new Date - messageState.timestamp; On 2017/05/15 22:36:54, kelvinp wrote: > s/Date/Date() for consistency Done. https://codereview.chromium.org/2887573002/diff/1/remoting/webapp/crd/js/butt... remoting/webapp/crd/js/butter_bar.js:96: !this.messages_[this.currentMessage_].dismissable || On 2017/05/15 22:36:54, kelvinp wrote: > On the first run, messageState.index is set to -1, > this.currentMessage_ is also -1 > > This will execute > !this.messages_[this.currentMessage_] > which will cause index out of bound We don't call sync.get() if currentMessage_ is -1, so this won't be executed.
sergeyu@chromium.org changed reviewers: - sergeyu@google.com
lgtm
The CQ bit was checked by jamiewalch@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jamiewalch@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jamiewalch@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kelvinp@chromium.org Link to the patchset: https://codereview.chromium.org/2887573002/#ps40001 (title: "Restore clock in tearDown.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jamiewalch@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by jamiewalch@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495122327991810, "parent_rev": "80eb240f54aa29f667898de5fdd34984a08903d2", "commit_rev": "53ea5fe3473c86b5243ba83f9d0fb20761ac1fe3"}
Message was sent while issue was closed.
Description was changed from ========== Add deprecation messages. ========== to ========== Add deprecation messages. Review-Url: https://codereview.chromium.org/2887573002 Cr-Commit-Position: refs/heads/master@{#472851} Committed: https://chromium.googlesource.com/chromium/src/+/53ea5fe3473c86b5243ba83f9d0f... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/53ea5fe3473c86b5243ba83f9d0f... |