Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2887563002:
[ObjC ARC] Converts ios/chrome/test/base:unit_tests to ARC. (Closed)
|
Created:
3 years, 7 months ago by liaoyuke Modified:
3 years, 7 months ago CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[ObjC ARC] Converts ios/chrome/test/base:unit_tests to ARC.
Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
Review-Url: https://codereview.chromium.org/2887563002
Cr-Commit-Position: refs/heads/master@{#472471}
Committed: https://chromium.googlesource.com/chromium/src/+/0d45a3eaaabb9a4ee55fffb80430116bd8271b75
Patch Set 1 #
Messages
Total messages: 23 (14 generated)
The CQ bit was checked by liaoyuke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
liaoyuke@chromium.org changed reviewers: + stkhapugin@chromium.org
Hi Stepan, PTAL. Thank you very much!
lgtm
The CQ bit was checked by liaoyuke@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by liaoyuke@chromium.org
Description was changed from ========== [ObjC ARC] Converts ios/chrome/test/base:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ========== to ========== [ObjC ARC] Converts ios/chrome/test/base:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ==========
liaoyuke@chromium.org changed reviewers: + baxley@chromium.org
Hey Mike, PTAL for owner's approval. Thank you very much!
lgtm
The CQ bit was checked by liaoyuke@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by liaoyuke@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1495034301494380, "parent_rev":
"44f871a7d7cb39ef8bda0aaf75ac31194463f50a", "commit_rev":
"0d45a3eaaabb9a4ee55fffb80430116bd8271b75"}
Message was sent while issue was closed.
Description was changed from ========== [ObjC ARC] Converts ios/chrome/test/base:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ========== to ========== [ObjC ARC] Converts ios/chrome/test/base:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2887563002 Cr-Commit-Position: refs/heads/master@{#472471} Committed: https://chromium.googlesource.com/chromium/src/+/0d45a3eaaabb9a4ee55fffb80430... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0d45a3eaaabb9a4ee55fffb80430... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
