Introduced WebFactory and WebFactoryImpl for constructing web/ classes

third_party/WebKit/Source/web/WebViewImpl.cpp

Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 8cc7d34fdd4e19c7c383787aadecacf3ba504892..bf4124e03f6909b2a988df5b396d78a8377b022c 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -33,6 +33,7 @@
 #include <memory>
 #include "core/CSSValueKeywords.h"
 #include "core/HTMLNames.h"
+#include "core/WebFactory.h"
 #include "core/clipboard/DataObject.h"
 #include "core/dom/ContextFeaturesClientImpl.h"
 #include "core/dom/Document.h"
@@ -338,7 +339,7 @@ WebViewImpl::WebViewImpl(WebViewClient* client,
                          WebPageVisibilityState visibility_state)
     : client_(client),
       spell_check_client_(nullptr),
-      chrome_client_impl_(ChromeClientImpl::Create(this)),
+      chrome_client_(WebFactory::GetInstance().CreateChromeClient(this)),

[haraken, 2017/05/23 01:56:35]

Just to clarify: How will this code be in the end state? Will this be reverted
back to:

  chrome_client_impl_(ChromeClientImpl::Create(this))

?

(In the real end state we should remove ChromeClientImpl though.)

[sashab, 2017/05/29 04:34:01]

Yes to both. :)

       context_menu_client_impl_(this),
       editor_client_impl_(this),
       spell_checker_client_impl_(this),
@@ -387,7 +388,7 @@ WebViewImpl::WebViewImpl(WebViewClient* client,
       last_frame_time_monotonic_(0),
       override_compositor_visibility_(false) {
   Page::PageClients page_clients;
-  page_clients.chrome_client = chrome_client_impl_.Get();
+  page_clients.chrome_client = chrome_client_.Get();
   page_clients.context_menu_client = &context_menu_client_impl_;
   page_clients.editor_client = &editor_client_impl_;
   page_clients.spell_checker_client = &spell_checker_client_impl_;