Introduced WebFactory and WebFactoryImpl for constructing web/ classes

third_party/WebKit/Source/web/WebViewImpl.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "web/WebViewImpl.h"
 
 #include <memory>
 #include "core/CSSValueKeywords.h"
 #include "core/HTMLNames.h"
+#include "core/WebFactory.h"
 #include "core/clipboard/DataObject.h"
 #include "core/dom/ContextFeaturesClientImpl.h"
 #include "core/dom/Document.h"
 #include "core/dom/DocumentUserGestureToken.h"
 #include "core/dom/Fullscreen.h"
 #include "core/dom/LayoutTreeBuilderTraversal.h"
 #include "core/dom/Text.h"
 #include "core/editing/EditingUtilities.h"
 #include "core/editing/Editor.h"
 #include "core/editing/FrameSelection.h"
@@ skipping 285 matching lines @@
 // static
 HashSet<WebViewBase*>& WebViewBase::AllInstances() {
   DEFINE_STATIC_LOCAL(HashSet<WebViewBase*>, all_instances, ());
   return all_instances;
 }
 
 WebViewImpl::WebViewImpl(WebViewClient* client,
                          WebPageVisibilityState visibility_state)
     : client_(client),
       spell_check_client_(nullptr),
-      chrome_client_impl_(ChromeClientImpl::Create(this)),
+      chrome_client_(WebFactory::GetInstance().CreateChromeClient(this)),

[haraken, 2017/05/23 01:56:35]

Just to clarify: How will this code be in the end state? Will this be reverted
back to:

  chrome_client_impl_(ChromeClientImpl::Create(this))

?

(In the real end state we should remove ChromeClientImpl though.)

[sashab, 2017/05/29 04:34:01]

Yes to both. :)

       context_menu_client_impl_(this),
       editor_client_impl_(this),
       spell_checker_client_impl_(this),
       storage_client_impl_(this),
       should_auto_resize_(false),
       zoom_level_(0),
       minimum_zoom_level_(ZoomFactorToZoomLevel(kMinTextSizeMultiplier)),
       maximum_zoom_level_(ZoomFactorToZoomLevel(kMaxTextSizeMultiplier)),
       zoom_factor_for_device_scale_factor_(0.f),
       maximum_legible_scale_(1),
@@ skipping 28 matching lines @@
       elastic_overscroll_(FloatSize()),
       mutator_(nullptr),
       scheduler_(WTF::WrapUnique(Platform::Current()
                                      ->CurrentThread()
                                      ->Scheduler()
                                      ->CreateWebViewScheduler(this, this)
                                      .release())),
       last_frame_time_monotonic_(0),
       override_compositor_visibility_(false) {
   Page::PageClients page_clients;
-  page_clients.chrome_client = chrome_client_impl_.Get();
+  page_clients.chrome_client = chrome_client_.Get();
   page_clients.context_menu_client = &context_menu_client_impl_;
   page_clients.editor_client = &editor_client_impl_;
   page_clients.spell_checker_client = &spell_checker_client_impl_;
 
   page_ = Page::CreateOrdinary(page_clients);
   MediaKeysController::ProvideMediaKeysTo(*page_, &media_keys_client_impl_);
   ProvideSpeechRecognitionTo(
       *page_, SpeechRecognitionClientProxy::Create(
                   client ? client->SpeechRecognizer() : nullptr));
   ProvideContextFeaturesTo(*page_, ContextFeaturesClientImpl::Create());
@@ skipping 3761 matching lines @@
   if (focused_frame->LocalFrameRoot() != MainFrameImpl()->GetFrame())
     return nullptr;
   return focused_frame;
 }
 
 LocalFrame* WebViewImpl::FocusedLocalFrameAvailableForIme() const {
   return ime_accept_events_ ? FocusedLocalFrameInWidget() : nullptr;
 }
 
 }  // namespace blink