Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2887493003: Modify headless_renderer target to avoid empty static_library in non windows component builds (Closed)

Created:
3 years, 7 months ago by dvallet
Modified:
3 years, 7 months ago
Reviewers:
Nico, Sami, Eric Seckler
CC:
chromium-reviews, Nico
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Modify headless_renderer target to avoid empty static_library in non windows component builds BUG=722338 Review-Url: https://codereview.chromium.org/2887493003 Cr-Commit-Position: refs/heads/master@{#472117} Committed: https://chromium.googlesource.com/chromium/src/+/d4531676e8dc43858dcae08deb1308f87ce9275f

Patch Set 1 #

Patch Set 2 : Updated upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -39 lines) Patch
M headless/BUILD.gn View 1 5 chunks +23 lines, -39 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
dvallet
PTAL, verified in Linux/Windows/Mac builds
3 years, 7 months ago (2017-05-16 01:16:30 UTC) #4
Sami
lgtm, thanks!
3 years, 7 months ago (2017-05-16 12:49:07 UTC) #16
Nico
lgtm
3 years, 7 months ago (2017-05-16 15:03:50 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887493003/20001
3 years, 7 months ago (2017-05-16 15:04:16 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 15:59:51 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d4531676e8dc43858dcae08deb13...

Powered by Google App Engine
This is Rietveld 408576698