|
|
Chromium Code Reviews
DescriptionModify headless_renderer target to avoid empty static_library in non windows component builds
BUG=722338
Review-Url: https://codereview.chromium.org/2887493003
Cr-Commit-Position: refs/heads/master@{#472117}
Committed: https://chromium.googlesource.com/chromium/src/+/d4531676e8dc43858dcae08deb1308f87ce9275f
Patch Set 1 #Patch Set 2 : Updated upstream #Messages
Total messages: 23 (18 generated)
The CQ bit was checked by dvallet@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dvallet@chromium.org changed reviewers: + skyostil@chromium.org, thakis@chromium.org
PTAL, verified in Linux/Windows/Mac builds
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dvallet@chromium.org changed reviewers: + eseckler@chromium.org - thakis@chromium.org
The CQ bit was checked by dvallet@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dvallet@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm, thanks!
thakis@chromium.org changed reviewers: + thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494947030196900,
"parent_rev": "b7ad055459988d9431b8e67118658a4c9cc2d470", "commit_rev":
"d4531676e8dc43858dcae08deb1308f87ce9275f"}
Message was sent while issue was closed.
Description was changed from ========== Modify headless_renderer target to avoid empty static_library in non windows component builds BUG=722338 ========== to ========== Modify headless_renderer target to avoid empty static_library in non windows component builds BUG=722338 Review-Url: https://codereview.chromium.org/2887493003 Cr-Commit-Position: refs/heads/master@{#472117} Committed: https://chromium.googlesource.com/chromium/src/+/d4531676e8dc43858dcae08deb13... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d4531676e8dc43858dcae08deb13... |
