Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2887463003: [ash-md] Removed unwanted TODO from ShelfWidget::DelegateView::opaque_background_ (Closed)

Created:
3 years, 7 months ago by bruthig
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Removed unwanted TODO from ShelfWidget::DelegateView::opaque_background_ Removinga stale TODO after some learning the |opaque_background_| is a good implementation. BUG=621551 Review-Url: https://codereview.chromium.org/2887463003 Cr-Commit-Position: refs/heads/master@{#471914} Committed: https://chromium.googlesource.com/chromium/src/+/ce7c55b8355104296e2c369333b591ad9e195331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ash/shelf/shelf_widget.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
bruthig
sky@, can you take a quick look?
3 years, 7 months ago (2017-05-15 20:50:28 UTC) #4
sky
LGTM
3 years, 7 months ago (2017-05-15 21:22:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887463003/1
3 years, 7 months ago (2017-05-15 21:36:34 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 21:47:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ce7c55b8355104296e2c369333b5...

Powered by Google App Engine
This is Rietveld 408576698