Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2887453004: Minor cleanup of error reporting in plugins (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M pkg/analyzer_plugin/lib/plugin/plugin.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol.dart View 1 chunk +10 lines, -11 lines 0 comments Download
M pkg/analyzer_plugin/lib/src/protocol/protocol_internal.dart View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 7 months ago (2017-05-15 22:06:30 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-15 22:11:10 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-15 23:48:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4c487c806b8d36660bee044abd4ec09122b4324c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698