Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1279)

Unified Diff: pkg/analyzer_plugin/lib/src/protocol/protocol_internal.dart

Issue 2887453004: Minor cleanup of error reporting in plugins (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer_plugin/lib/protocol/protocol.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_plugin/lib/src/protocol/protocol_internal.dart
diff --git a/pkg/analyzer_plugin/lib/src/protocol/protocol_internal.dart b/pkg/analyzer_plugin/lib/src/protocol/protocol_internal.dart
index 207755ee3742146cb9b2ff5be7ceff8f84926083..75d093c6601c21ba1f962f3c1cdf9df76514ca3b 100644
--- a/pkg/analyzer_plugin/lib/src/protocol/protocol_internal.dart
+++ b/pkg/analyzer_plugin/lib/src/protocol/protocol_internal.dart
@@ -441,9 +441,9 @@ class RequestDecoder extends JsonDecoder {
/**
* The request being deserialized.
*/
- final Request _request;
+ final Request request;
- RequestDecoder(this._request);
+ RequestDecoder(this.request);
@override
RefactoringKind get refactoringKind {
@@ -461,14 +461,14 @@ class RequestDecoder extends JsonDecoder {
buffer.write(JSON.encode(actual));
buffer.write('"');
}
- return new RequestFailure(RequestErrorFactory.invalidParameter(
- _request, jsonPath, buffer.toString()));
+ return new RequestFailure(
+ RequestErrorFactory.invalidParameter(jsonPath, buffer.toString()));
}
@override
dynamic missingKey(String jsonPath, String key) {
return new RequestFailure(RequestErrorFactory.invalidParameter(
- _request, jsonPath, 'Expected to contain key ${JSON.encode(key)}'));
+ jsonPath, 'Expected to contain key ${JSON.encode(key)}'));
}
}
« no previous file with comments | « pkg/analyzer_plugin/lib/protocol/protocol.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698