Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2887453003:
bindings: Allow multiple enum declarations (Closed)
Descriptionbindings: Allow multiple enum declarations
crrev.com/2868413005 added a dup of an IDL enum to work around
core/module separation. We need to allow multiple enum declarations
if they have the same valid values.
BUG=721933
Review-Url: https://codereview.chromium.org/2887453003
Cr-Commit-Position: refs/heads/master@{#471912}
Committed: https://chromium.googlesource.com/chromium/src/+/43c2711c305b811722270723ad12e11d52f7acef
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
The CQ bit was checked by bashi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bashi@chromium.org changed reviewers: + haraken@chromium.org, peria@chromium.org, yukishiino@chromium.org
PTAL
LGTM
The CQ bit was unchecked by bashi@chromium.org
The CQ bit was checked by bashi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
On 2017/05/15 18:48:33, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started once the patch has received an L-G-T-M from a full > committer. > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > full super star committer. > Committers are members of the group "project-chromium-committers". > Note that this has nothing to do with OWNERS files. LGTM (from a right address).
On 2017/05/15 19:44:37, haraken1 wrote: > On 2017/05/15 18:48:33, commit-bot: I haz the power wrote: > > No L-G-T-M from a valid reviewer yet. > > CQ run can only be started once the patch has received an L-G-T-M from a full > > committer. > > Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a > > full super star committer. > > Committers are members of the group "project-chromium-committers". > > Note that this has nothing to do with OWNERS files. > > LGTM (from a right address). LGTM (Sorry, my account was messed up...)
The CQ bit was checked by bashi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494882053679210, "parent_rev":
"0b772bacda31df9e862388f4859f1d56d3d217ae", "commit_rev":
"43c2711c305b811722270723ad12e11d52f7acef"}
Message was sent while issue was closed.
Description was changed from ========== bindings: Allow multiple enum declarations crrev.com/2868413005 added a dup of an IDL enum to work around core/module separation. We need to allow multiple enum declarations if they have the same valid values. BUG=721933 ========== to ========== bindings: Allow multiple enum declarations crrev.com/2868413005 added a dup of an IDL enum to work around core/module separation. We need to allow multiple enum declarations if they have the same valid values. BUG=721933 Review-Url: https://codereview.chromium.org/2887453003 Cr-Commit-Position: refs/heads/master@{#471912} Committed: https://chromium.googlesource.com/chromium/src/+/43c2711c305b811722270723ad12... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/43c2711c305b811722270723ad12...
Message was sent while issue was closed.
LGTM. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
