Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2887433005: Remove references to surround_data_ in ComputedStyle. (Closed)

Created:
3 years, 7 months ago by nainar
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove references to surround_data_ in ComputedStyle. To allow changes to where fields are stored, ComputedStyle code should not refer directly to a group, as that code will break when we change groups. This patch removes references to surround_data_ in ComputedStyle, replacing with generated or handwritten getters. References in the cpp file have already been removed. BUG=710938 Review-Url: https://codereview.chromium.org/2887433005 Cr-Commit-Position: refs/heads/master@{#472322} Committed: https://chromium.googlesource.com/chromium/src/+/de633202221100c5bc812309bdff65f7faa6b0d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 5 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
nainar
shend@, PTAL? Thanks!
3 years, 7 months ago (2017-05-16 07:36:13 UTC) #4
shend
lgtm
3 years, 7 months ago (2017-05-16 07:37:45 UTC) #5
nainar
alancutter@, PTAL? Thanks!
3 years, 7 months ago (2017-05-16 07:42:02 UTC) #7
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-05-16 07:45:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887433005/1
3 years, 7 months ago (2017-05-17 00:16:47 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 04:20:12 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/de633202221100c5bc812309bdff...

Powered by Google App Engine
This is Rietveld 408576698