Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2887413004: chromeos: moves setting of touch state to a separate class (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, rjkroege, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: moves setting of touch state to a separate class For mash/mushrome we need setting of touch state to happen in mus. This patch separates out setting into a separate class so that ash in mus/mash can plug in a class that makes mojo calls. BUG=705686 TEST=covered by tests R=oshima@chromium.org Review-Url: https://codereview.chromium.org/2887413004 Cr-Commit-Position: refs/heads/master@{#473474} Committed: https://chromium.googlesource.com/chromium/src/+/2f68b6fe7c3249c69aa561addd4a54b257e2d2a4

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : merge #

Total comments: 4

Patch Set 4 : merge #

Patch Set 5 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -33 lines) Patch
M ash/shell.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ash/touch/ash_touch_transform_controller.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M ash/touch/ash_touch_transform_controller.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M services/ui/display/screen_manager_ozone_internal.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/display/manager/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/display/manager/chromeos/DEPS View 1 1 chunk +14 lines, -0 lines 0 comments Download
A ui/display/manager/chromeos/default_touch_transform_setter.h View 1 chunk +30 lines, -0 lines 0 comments Download
A ui/display/manager/chromeos/default_touch_transform_setter.cc View 1 chunk +31 lines, -0 lines 0 comments Download
A ui/display/manager/chromeos/touch_device_transform.h View 1 chunk +26 lines, -0 lines 0 comments Download
A ui/display/manager/chromeos/touch_device_transform.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M ui/display/manager/chromeos/touch_transform_controller.h View 1 2 3 4 6 chunks +31 lines, -7 lines 0 comments Download
M ui/display/manager/chromeos/touch_transform_controller.cc View 1 6 chunks +37 lines, -20 lines 0 comments Download
M ui/display/manager/chromeos/touch_transform_controller_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
A ui/display/manager/chromeos/touch_transform_setter.h View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
sky
3 years, 7 months ago (2017-05-18 18:08:05 UTC) #1
oshima
lgtm https://codereview.chromium.org/2887413004/diff/40001/ui/display/manager/chromeos/touch_transform_controller.h File ui/display/manager/chromeos/touch_transform_controller.h (right): https://codereview.chromium.org/2887413004/diff/40001/ui/display/manager/chromeos/touch_transform_controller.h#newcode88 ui/display/manager/chromeos/touch_transform_controller.h:88: // For the provided |display| update the touch ...
3 years, 7 months ago (2017-05-19 23:54:00 UTC) #10
sky
https://codereview.chromium.org/2887413004/diff/40001/ui/display/manager/chromeos/touch_transform_controller.h File ui/display/manager/chromeos/touch_transform_controller.h (right): https://codereview.chromium.org/2887413004/diff/40001/ui/display/manager/chromeos/touch_transform_controller.h#newcode88 ui/display/manager/chromeos/touch_transform_controller.h:88: // For the provided |display| update the touch radius ...
3 years, 7 months ago (2017-05-21 14:42:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887413004/80001
3 years, 7 months ago (2017-05-21 14:42:46 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-21 16:08:58 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/2f68b6fe7c3249c69aa561addd4a...

Powered by Google App Engine
This is Rietveld 408576698