Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2887413003: [DevTools] fix name for module scope in scopes sidebar pane (Closed)

Created:
3 years, 7 months ago by kozy
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] fix name for module scope in scopes sidebar pane BUG=chromium:721845 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2887413003 Cr-Commit-Position: refs/heads/master@{#473128} Committed: https://chromium.googlesource.com/chromium/src/+/cb18c930d6096aa8a2859702dd0a404b29fcb5ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-es6-harmony-scopes.html View 2 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-es6-harmony-scopes-expected.txt View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
kozy
Dmitry, please take a look.
3 years, 7 months ago (2017-05-18 17:39:36 UTC) #1
dgozman
lgtm
3 years, 7 months ago (2017-05-18 17:56:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887413003/1
3 years, 7 months ago (2017-05-18 18:04:20 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/449291)
3 years, 7 months ago (2017-05-19 03:08:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887413003/1
3 years, 7 months ago (2017-05-19 06:45:45 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 08:28:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cb18c930d6096aa8a2859702dd0a...

Powered by Google App Engine
This is Rietveld 408576698