[ObjC ARC] Converts ios/public/provider/chrome/browser:test_support to ARC.

[ObjC ARC] Converts ios/public/provider/chrome/browser:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2887403002
Cr-Commit-Position: refs/heads/master@{#475629}
Committed: https://chromium.googlesource.com/chromium/src/+/ad2efd926bcfde0958c539057fd92f3dcb7820df

[lindsayw, 2017-05-18 16:43:46]

The CQ bit was checked by lindsayw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 16:44:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 18:00:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 18:00:21]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lindsayw, 2017-05-18 19:12:57]

The CQ bit was checked by lindsayw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 19:14:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 22:45:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 22:45:45]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lindsayw, 2017-05-19 12:06:29]

The CQ bit was checked by lindsayw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 12:06:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 13:16:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 13:16:13]

Dry run: This issue passed the CQ dry run.

[lindsayw, 2017-05-19 14:07:44]

lindsayw@chromium.org changed reviewers:
+ stkhapugin@chromium.org

[lindsayw, 2017-05-19 14:07:44]

Thanks for your review!

[lindsayw, 2017-05-25 14:34:01]

lindsayw@chromium.org changed reviewers:
+ rohitrao@chromium.org
- stkhapugin@chromium.org

[lindsayw, 2017-05-25 14:34:02]

Hi Rohit,
Can you please review since Paris is out and you are owner?
Thanks,

[lindsayw, 2017-05-30 11:52:37]

Description was changed from

==========
[ObjC ARC] Converts ios/public/provider/chrome/browser:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/public/provider/chrome/browser:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

[lindsayw, 2017-05-30 11:52:37]

lindsayw@chromium.org changed reviewers:
+ stkhapugin@chromium.org

[stkhapugin, 2017-05-30 13:45:13]

lgtm

[rohitrao (ping after 24h), 2017-05-30 15:10:16]

lgtm

https://codereview.chromium.org/2887403002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/test_chrome_browser_provider.mm (right):

https://codereview.chromium.org/2887403002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/test_chrome_browser_provider.mm:65:
UITextField<TextFieldStyling>* TestChromeBrowserProvider::CreateStyledTextField(
@stk how does ARC handle a C++ method that returns an ObjC object?  Do we need
to do anything special here with annotations?

[stkhapugin, 2017-05-30 15:29:19]

https://codereview.chromium.org/2887403002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/test_chrome_browser_provider.mm (right):

https://codereview.chromium.org/2887403002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/test_chrome_browser_provider.mm:65:
UITextField<TextFieldStyling>* TestChromeBrowserProvider::CreateStyledTextField(
On 2017/05/30 15:10:16, rohitrao (ping after 24h) wrote:
> @stk how does ARC handle a C++ method that returns an ObjC object?  Do we need
> to do anything special here with annotations?

In this case, the returned object must have a retain count of +1 to match the
pre-ARC implementation. To achieve this, NS_RETURNS_RETAINED annotation is
necessary. However, it is already in place in the header:

  UITextField<TextFieldStyling>* CreateStyledTextField(
      CGRect frame) const override NS_RETURNS_RETAINED;

Thus no need to add anything.

[lindsayw, 2017-05-30 17:26:16]

The CQ bit was checked by lindsayw@chromium.org

[commit-bot: I haz the power, 2017-05-30 17:26:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 19:37:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496165176306640, "parent_rev":
"704e6128000a326e113e6cbcb3945fc34586ee29", "commit_rev":
"ad2efd926bcfde0958c539057fd92f3dcb7820df"}

[commit-bot: I haz the power, 2017-05-30 19:37:55]

Description was changed from

==========
[ObjC ARC] Converts ios/public/provider/chrome/browser:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/public/provider/chrome/browser:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2887403002
Cr-Commit-Position: refs/heads/master@{#475629}
Committed:
https://chromium.googlesource.com/chromium/src/+/ad2efd926bcfde0958c539057fd9...
==========

[commit-bot: I haz the power, 2017-05-30 19:37:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ad2efd926bcfde0958c539057fd9...