Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2887363002: Always use the new style avatar button for the glass frame on Windows 10 (Closed)

Created:
3 years, 7 months ago by Sungmann Cho
Modified:
3 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Always use the new style avatar button for the glass frame on Windows 10 The new style avatar button is currently used only for the non-themed glass frame, but it would be more reasonable to use it for both the themed and the non-themed glass frame for aesthetic consistency. BUG=723070 Review-Url: https://codereview.chromium.org/2887363002 Cr-Commit-Position: refs/heads/master@{#472981} Committed: https://chromium.googlesource.com/chromium/src/+/8f752dd6fb26463148e8720f2353f62a31939cdd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/ui/views/profiles/avatar_button.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Sungmann Cho
This is a follow-up CL to https://codereview.chromium.org/2891573002/. Please take a look. Thanks!
3 years, 7 months ago (2017-05-18 15:19:50 UTC) #2
Peter Kasting
LGTM, thanks!
3 years, 7 months ago (2017-05-18 17:12:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887363002/1
3 years, 7 months ago (2017-05-18 18:34:29 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 00:07:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8f752dd6fb26463148e8720f2353...

Powered by Google App Engine
This is Rietveld 408576698