Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2887293002: Move StyleRareNonInheritedData::has* methods to ComputedStyle. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move StyleRareNonInheritedData::has* methods to ComputedStyle. When we generate StyleRareNonInheritedData, we would no longer have handwritten helper functions on the class. Hence, we need to move all the helper functions on StyleRareNonInheritedData to ComputedStyle. This patch concerns three helper functions in ComputedStyle: - HasFilters: Moved to ComputedStyle. - HasBackdropFilters: Deleted as it was unused. - HasOpacity: Same helper already exists on ComputedStyle, deleted. BUG=628043 Review-Url: https://codereview.chromium.org/2887293002 Cr-Commit-Position: refs/heads/master@{#474182} Committed: https://chromium.googlesource.com/chromium/src/+/aae42e696973ff14132cb94ef1cc304c2deb0f9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
shend
Hi Naina, PTAL
3 years, 7 months ago (2017-05-18 06:22:57 UTC) #2
nainar
lgtm
3 years, 7 months ago (2017-05-18 06:26:43 UTC) #5
shend
Hi Eddy PTAL :)
3 years, 7 months ago (2017-05-18 06:39:57 UTC) #7
shend
Subbing in Alan, PTAL :)
3 years, 7 months ago (2017-05-22 02:36:25 UTC) #11
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-05-24 03:00:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887293002/1
3 years, 7 months ago (2017-05-24 06:04:50 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 06:10:28 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aae42e696973ff14132cb94ef1cc...

Powered by Google App Engine
This is Rietveld 408576698