../platform/ => public/platform/

../platform/ => public/platform/

We currently have a DEPS rule in third_party/WebKit/public/web/ that's flagging
header includes that start with "../platform" as violations. This means
engineers who add extra includes and attempt to match the existing style are
wasting time trying to debug/work around these violations. This CL fixes all
the existing includes of this form in this directory so they're written in a
form that won't trigger a DEPS violation.

Note: this CL was created by doing a find-and-replace in this directory for
Review-Url: https://codereview.chromium.org/2887233003
Cr-Commit-Position: refs/heads/master@{#472691}
Committed: https://chromium.googlesource.com/chromium/src/+/60b43f716972ded8acc86db0ac60fb524f061bf9

[rlanday, 2017-05-17 23:12:32]

Description was changed from

==========
../platform/ => public/platform/

We currently have a DEPS rule in third_party/WebKit/public/web/ that's flagging
header includes that start with "../platform" as violations. This means
engineers who add extra includes and attempt to match the existing style are
wasting time trying to debug/work around these violations. This CL fixes all
the existing includes of this form in this directory so they're written in a
form that won't trigger a DEPS violation.
==========

to

==========
../platform/ => public/platform/

We currently have a DEPS rule in third_party/WebKit/public/web/ that's flagging
header includes that start with "../platform" as violations. This means
engineers who add extra includes and attempt to match the existing style are
wasting time trying to debug/work around these violations. This CL fixes all
the existing includes of this form in this directory so they're written in a
form that won't trigger a DEPS violation.

Note: this CL was created by doing a find-and-replace in this directory for
"../platform" => "public/platform", and then another one for
"../public/platform" to "public/platform" to clean up some "../../platform"
cases.
==========

[rlanday, 2017-05-17 23:12:32]

rlanday@chromium.org changed reviewers:
+ aelias@chromium.org

[rlanday, 2017-05-17 23:13:05]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 23:14:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-05-17 23:16:45]

lgtm, thanks!  +amaralp@ who ran into this too.

[commit-bot: I haz the power, 2017-05-17 23:36:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 23:36:15]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[rlanday, 2017-05-17 23:54:41]

So, apparently we have two files that define the same enum, one with the "k"
prefix and one without:

third_party/WebKit/public/platform/WebTextInputType.h
third_party/WebKit/public/web/WebTextInputType.h

They also have the same include guard #ifdef. So this CL may not be as
straightforward as I hoped, we'll probably need to clean up a few things first.

[rlanday, 2017-05-18 00:04:24]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[rlanday, 2017-05-18 00:05:26]

I think the issue isn't actually with this change, but rather running "git cl
format" to put the headers in the correct order. Apparently some of this code is
fragile and breaks if the headers are reordered :(

aelias, if the try bots pass without the header reorder, does this still look
good?

[commit-bot: I haz the power, 2017-05-18 00:05:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 00:26:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 00:26:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rlanday, 2017-05-18 00:36:36]

Nevermind, there are more errors that look like this:

[2180/9745] CXX
obj/components/autofill/content/renderer/test_support/test_password_autofill_agent.o
FAILED:
obj/components/autofill/content/renderer/test_support/test_password_autofill_agent.o

...
In file included from
../../components/autofill/content/renderer/test_password_autofill_agent.cc:5:
In file included from
../../components/autofill/content/renderer/test_password_autofill_agent.h:8:
In file included from
../../components/autofill/content/renderer/password_autofill_agent.h:15:
In file included from
../../components/autofill/content/renderer/autofill_agent.h:20:
In file included from
../../components/autofill/content/renderer/page_click_tracker.h:12:
../../third_party/WebKit/public/web/WebNode.h:34:10: fatal error:
'public/platform/WebCommon.h' file not found
#include "public/platform/WebCommon.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
[2181/9745] CXX
obj/extensions/browser/guest_view/web_view/web_view/web_view_permission_helper.o
[2182/9745] CXX obj/components/autofill/content/renderer/renderer/form_cache.o
[2183/9745] CXX
obj/components/autofill/content/renderer/test_support/test_password_generation_agent.o
FAILED:
obj/components/autofill/content/renderer/test_support/test_password_generation_agent.o

...
In file included from
../../components/autofill/content/renderer/test_password_generation_agent.cc:5:
In file included from
../../components/autofill/content/renderer/test_password_generation_agent.h:12:
In file included from
../../components/autofill/content/renderer/password_generation_agent.h:23:
In file included from ../../third_party/WebKit/public/web/WebInputElement.h:34:
../../third_party/WebKit/public/web/WebFormControlElement.h:34:10: fatal error:
'public/platform/WebString.h' file not found
#include "public/platform/WebString.h"


I think there's some test case code that's not set up to build correctly
(missing deps?)...this is kind of making me not want to go ahead with this
change, unless there's an easy way to update these tests so they build properly.

[aelias_OOO_until_Jul13, 2017-05-18 00:45:25]

Maybe just exclude the headers with problems for now and land the rest.

[rlanday, 2017-05-18 01:13:23]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 01:14:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 01:36:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 01:36:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rlanday, 2017-05-18 01:42:39]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 01:43:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 02:05:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 02:05:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[rlanday, 2017-05-18 02:15:49]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 02:17:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-05-18 02:42:17]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 02:43:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 03:05:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 03:05:52]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rlanday, 2017-05-18 03:30:24]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 03:34:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-05-18 04:48:22]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-05-18 04:48:22]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org
Link to the patchset: https://codereview.chromium.org/2887233003/#ps120001
(title: "Revert a few more header includes")

[commit-bot: I haz the power, 2017-05-18 04:49:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 05:54:47]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1495082902237800,
"parent_rev": "3ac652888aa83444ea37c627b6537af80bee772b", "commit_rev":
"60b43f716972ded8acc86db0ac60fb524f061bf9"}

[commit-bot: I haz the power, 2017-05-18 05:54:58]

Description was changed from

==========
../platform/ => public/platform/

We currently have a DEPS rule in third_party/WebKit/public/web/ that's flagging
header includes that start with "../platform" as violations. This means
engineers who add extra includes and attempt to match the existing style are
wasting time trying to debug/work around these violations. This CL fixes all
the existing includes of this form in this directory so they're written in a
form that won't trigger a DEPS violation.

Note: this CL was created by doing a find-and-replace in this directory for
"../platform" => "public/platform", and then another one for
"../public/platform" to "public/platform" to clean up some "../../platform"
cases.
==========

to

==========
../platform/ => public/platform/

We currently have a DEPS rule in third_party/WebKit/public/web/ that's flagging
header includes that start with "../platform" as violations. This means
engineers who add extra includes and attempt to match the existing style are
wasting time trying to debug/work around these violations. This CL fixes all
the existing includes of this form in this directory so they're written in a
form that won't trigger a DEPS violation.

Note: this CL was created by doing a find-and-replace in this directory for
Review-Url: https://codereview.chromium.org/2887233003
Cr-Commit-Position: refs/heads/master@{#472691}
Committed:
https://chromium.googlesource.com/chromium/src/+/60b43f716972ded8acc86db0ac60...
==========

[commit-bot: I haz the power, 2017-05-18 05:55:02]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/60b43f716972ded8acc86db0ac60...