Make EnableCaretInEditableText return false for user-triggered command and unfocused selection

Make EnableCaretInEditableText return false for user-triggered command and unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledRangeInEditableText() to fix
the behavior of the Transpose command.

BUG=722925
TEST=editing/execCommand/transpose_with_unfocused_selection.html

Review-Url: https://codereview.chromium.org/2887213003
Cr-Commit-Position: refs/heads/master@{#472668}
Committed: https://chromium.googlesource.com/chromium/src/+/1f462b4e66919d4104355e3883bf81b541f8754e

[Xiaocheng, 2017-05-17 20:26:50]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 20:28:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 23:10:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 23:10:49]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xiaocheng, 2017-05-17 23:12:31]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 23:14:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-18 00:08:34]

Description was changed from

==========
Make EnableCaretInEditableText return false for user-triggered command and
unfocused selection

BUG=
==========

to

==========
Make EnableCaretInEditableText return false for user-triggered command and
unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledRangeInEditableText() to fix
the behavior of the Transpose command.

BUG=722925
TEST=editing/execCommand/transpose_with_unfocused_selection.html
==========

[Xiaocheng, 2017-05-18 00:08:42]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-18 00:08:43]

PTAL.

[yosin_UTC9, 2017-05-18 00:57:57]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-05-18 00:57:59]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-05-18 00:58:00]

lgtm

[commit-bot: I haz the power, 2017-05-18 00:59:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 04:45:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495069079775810, "parent_rev":
"854b8bcfc787413293c86eddd979a3fd1936fb1a", "commit_rev":
"1f462b4e66919d4104355e3883bf81b541f8754e"}

[commit-bot: I haz the power, 2017-05-18 04:45:16]

Description was changed from

==========
Make EnableCaretInEditableText return false for user-triggered command and
unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledRangeInEditableText() to fix
the behavior of the Transpose command.

BUG=722925
TEST=editing/execCommand/transpose_with_unfocused_selection.html
==========

to

==========
Make EnableCaretInEditableText return false for user-triggered command and
unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledRangeInEditableText() to fix
the behavior of the Transpose command.

BUG=722925
TEST=editing/execCommand/transpose_with_unfocused_selection.html

Review-Url: https://codereview.chromium.org/2887213003
Cr-Commit-Position: refs/heads/master@{#472668}
Committed:
https://chromium.googlesource.com/chromium/src/+/1f462b4e66919d4104355e3883bf...
==========

[commit-bot: I haz the power, 2017-05-18 04:45:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1f462b4e66919d4104355e3883bf...